Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r367A-002BXo-3D for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 02:58:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r3677-00Cui9-Fz for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Nov 2023 02:58:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3677-00Cui0-49 for pgsql-hackers@lists.postgresql.org; Wed, 15 Nov 2023 02:58:49 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3672-006UiR-Hv for pgsql-hackers@postgresql.org; Wed, 15 Nov 2023 02:58:47 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 910F360172; Wed, 15 Nov 2023 11:58:38 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_571d2c8ba3cbf2853d0ae6c817706653" Content-Transfer-Encoding: 7bit Date: Wed, 15 Nov 2023 11:58:38 +0900 From: torikoshia To: Michael Paquier Cc: Andres Freund , boekewurm+postgres@gmail.com, Kyotaro Horiguchi , pgsql-hackers@postgresql.org, bharath.rupireddyforpostgres@gmail.com Subject: Re: Add new option 'all' to pg_stat_reset_shared() In-Reply-To: References: <62d8244b05557a91e25914c02607b493@oss.nttdata.com> <20231109012952.fft2i356ofljugt6@awork3.anarazel.de> <37bce6feca33e0c0441cd33f9eaa51d6@oss.nttdata.com> <89C9D2DC-8239-4373-991A-18CC45D6A5FE@anarazel.de> <6c01af77007905c73751f42eea03aef5@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <350550211cf7d235cd92e5c7969e8f68@oss.nttdata.com> X-Sender: torikoshia@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_571d2c8ba3cbf2853d0ae6c817706653 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2023-11-15 09:47, Michael Paquier wrote: > On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote: >> Attached patch. > > You have forgotten to update the errhint at the end of > pg_stat_reset_shared(), where "slru" needs to be listed :) Oops, attached v2 patch. >> BTW currently the documentation explains all the arguments of >> pg_stat_reset_shared() in one line and I feel it's a bit hard to read. >> Attached patch uses . > > Yes, this one is a good idea because each target works on a different > system view so it becomes easier to understand what a target affects, > so I've applied this bit, without the slru addition. Thanks! > -- > Michael -- Regards, -- Atsushi Torikoshi NTT DATA Group Corporation --=_571d2c8ba3cbf2853d0ae6c817706653 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v2-0001-Add-ability-to-reset-pg_stat_slru-in-pg_stat_rese.patch Content-Disposition: attachment; filename=v2-0001-Add-ability-to-reset-pg_stat_slru-in-pg_stat_rese.patch; size=6460 RnJvbSA5MjgzZDI1Y2I5NmM5YzQyNTNkN2YzOWM0NjRiNjE1NzZiZDUyYTUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBdHN1c2hpIFRvcmlrb3NoaSA8dG9yaWtvc2hpYUBvc3MubnR0 ZGF0YS5jb20+CkRhdGU6IFdlZCwgMTUgTm92IDIwMjMgMTE6NDc6MTMgKzA5MDAKU3ViamVjdDog W1BBVENIIHYyXSBBZGQgYWJpbGl0eSB0byByZXNldCBwZ19zdGF0X3NscnUgaW4KIHBnX3N0YXRf cmVzZXRfc2hhcmVkKCkKCkN1cnJlbnRseSwgcGdfc3RhdF9yZXNldF9zaGFyZWQoKSBjYW4gbm90 IHJlc2V0IHBnX3N0YXRfc2xydQpuZXZlcnRoZWxlc3MgdGhpcyBpcyBvbmUgb2Ygc2hhcmVkIHN0 YXRpc3RpY3Mgdmlldy4KClRoaXMgcGF0Y2ggYWRkcyBhIG5ldyBhcmdtZW50ICdzbHJ1JyB0byBy ZXNldCBhbGwgdGhlIHJvd3MKaW4gcGdfc3RhdF9zbHJ1LgoKQ29uc2lkZXJpbmcgcGdfc3RhdF9y ZXNldF9zbHJ1KCkgd2FzIGludHJvZHVjZWQgaW4KMjhjYWM3MWJkMzY4KFBvc3RncmVTUUwgMTMp IGFuZCBpdCBjb3VsZCBpbXBhY3QgZXhpc3RpbmcKYXBwbGljYXRpb25zIGFuZCBpdCBjYW4gbm90 IG9ubHkgcmVzZXQgYWxsIHRoZSBlbnRyeSBidXQKY2FuIHNwZWNpZnkgd2hpY2ggZW50cnkgdG8g cmVzZXQsIHRoaXMgZnVuY3Rpb24gaXMgbGVmdAphcyBpdCBpcy4KLS0tCiBkb2Mvc3JjL3NnbWwv bW9uaXRvcmluZy5zZ21sICAgICAgICB8ICA2ICsrKysrCiBzcmMvYmFja2VuZC91dGlscy9hZHQv cGdzdGF0ZnVuY3MuYyB8ICA1ICsrKy0KIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMu b3V0IHwgMzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIHNyYy90ZXN0L3JlZ3Jlc3Mv c3FsL3N0YXRzLnNxbCAgICAgIHwgIDcgKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDUzIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL21vbml0 b3Jpbmcuc2dtbCBiL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKaW5kZXggMWU5OTEzYzhi Yy4uNDI1MDkwNDJhZCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dtbAor KysgYi9kb2Mvc3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sCkBAIC00NzQ5LDYgKzQ3NDksMTIgQEAg ZGVzY3JpcHRpb24gfCBXYWl0aW5nIGZvciBhIG5ld2x5IGluaXRpYWxpemVkIFdBTCBmaWxlIHRv IHJlYWNoIGR1cmFibGUgc3RvcmFnZQogICAgICAgICAgIHRoZSA8c3RydWN0bmFtZT5wZ19zdGF0 X3JlY292ZXJ5X3ByZWZldGNoPC9zdHJ1Y3RuYW1lPiB2aWV3LgogICAgICAgICAgPC9wYXJhPgog ICAgICAgICA8L2xpc3RpdGVtPgorICAgICAgICA8bGlzdGl0ZW0+CisgICAgICAgICA8cGFyYT4K KyAgICAgICAgICA8bGl0ZXJhbD5zbHJ1PC9saXRlcmFsPjogUmVzZXQgYWxsIHRoZSBjb3VudGVy cyBzaG93biBpbiB0aGUKKyAgICAgICAgICA8c3RydWN0bmFtZT5wZ19zdGF0X3NscnU8L3N0cnVj dG5hbWU+IHZpZXcuCisgICAgICAgICA8L3BhcmE+CisgICAgICAgIDwvbGlzdGl0ZW0+CiAgICAg ICAgIDxsaXN0aXRlbT4KICAgICAgICAgIDxwYXJhPgogICAgICAgICAgIDxsaXRlcmFsPndhbDwv bGl0ZXJhbD46IFJlc2V0IGFsbCB0aGUgY291bnRlcnMgc2hvd24gaW4gdGhlCmRpZmYgLS1naXQg YS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdzdGF0ZnVuY3MuYyBiL3NyYy9iYWNrZW5kL3V0aWxz L2FkdC9wZ3N0YXRmdW5jcy5jCmluZGV4IDNhOWY5YmM0ZmUuLjBjZWEzMjBjMDAgMTAwNjQ0Ci0t LSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCisrKyBiL3NyYy9iYWNrZW5k L3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCkBAIC0xNjk1LDYgKzE2OTUsNyBAQCBwZ19zdGF0X3Jl c2V0X3NoYXJlZChQR19GVU5DVElPTl9BUkdTKQogCQlwZ3N0YXRfcmVzZXRfb2Zfa2luZChQR1NU QVRfS0lORF9DSEVDS1BPSU5URVIpOwogCQlwZ3N0YXRfcmVzZXRfb2Zfa2luZChQR1NUQVRfS0lO RF9JTyk7CiAJCVhMb2dQcmVmZXRjaFJlc2V0U3RhdHMoKTsKKwkJcGdzdGF0X3Jlc2V0X29mX2tp bmQoUEdTVEFUX0tJTkRfU0xSVSk7CiAJCXBnc3RhdF9yZXNldF9vZl9raW5kKFBHU1RBVF9LSU5E X1dBTCk7CiAKIAkJUEdfUkVUVVJOX1ZPSUQoKTsKQEAgLTE3MTIsMTMgKzE3MTMsMTUgQEAgcGdf c3RhdF9yZXNldF9zaGFyZWQoUEdfRlVOQ1RJT05fQVJHUykKIAkJcGdzdGF0X3Jlc2V0X29mX2tp bmQoUEdTVEFUX0tJTkRfSU8pOwogCWVsc2UgaWYgKHN0cmNtcCh0YXJnZXQsICJyZWNvdmVyeV9w cmVmZXRjaCIpID09IDApCiAJCVhMb2dQcmVmZXRjaFJlc2V0U3RhdHMoKTsKKwllbHNlIGlmIChz dHJjbXAodGFyZ2V0LCAic2xydSIpID09IDApCisJCXBnc3RhdF9yZXNldF9vZl9raW5kKFBHU1RB VF9LSU5EX1NMUlUpOwogCWVsc2UgaWYgKHN0cmNtcCh0YXJnZXQsICJ3YWwiKSA9PSAwKQogCQlw Z3N0YXRfcmVzZXRfb2Zfa2luZChQR1NUQVRfS0lORF9XQUwpOwogCWVsc2UKIAkJZXJlcG9ydChF UlJPUiwKIAkJCQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfUEFSQU1FVEVSX1ZBTFVFKSwKIAkJ CQkgZXJybXNnKCJ1bnJlY29nbml6ZWQgcmVzZXQgdGFyZ2V0OiBcIiVzXCIiLCB0YXJnZXQpLAot CQkJCSBlcnJoaW50KCJUYXJnZXQgbXVzdCBiZSBcImFyY2hpdmVyXCIsIFwiYmd3cml0ZXJcIiwg XCJjaGVja3BvaW50ZXJcIiwgXCJpb1wiLCBcInJlY292ZXJ5X3ByZWZldGNoXCIsIG9yIFwid2Fs XCIuIikpKTsKKwkJCQkgZXJyaGludCgiVGFyZ2V0IG11c3QgYmUgXCJhcmNoaXZlclwiLCBcImJn d3JpdGVyXCIsIFwiY2hlY2twb2ludGVyXCIsIFwiaW9cIiwgXCJyZWNvdmVyeV9wcmVmZXRjaFwi LCBcInNscnVcIiwgb3IgXCJ3YWxcIi4iKSkpOwogCiAJUEdfUkVUVVJOX1ZPSUQoKTsKIH0KZGlm ZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0IGIvc3JjL3Rlc3Qv cmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKaW5kZXggNmVkMzU4NGE3Ni4uMTAzZWE0NTNkZiAx MDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKKysrIGIvc3Jj L3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKQEAgLTk2MCw2ICs5NjAsMjggQEAgU0VM RUNUIHN0YXRzX3Jlc2V0ID4gOidyZWNvdmVyeV9wcmVmZXRjaF9yZXNldF90cyc6OnRpbWVzdGFt cHR6IEZST00gcGdfc3RhdF9yZWMKICgxIHJvdykKIAogU0VMRUNUIHN0YXRzX3Jlc2V0IEFTIHJl Y292ZXJ5X3ByZWZldGNoX3Jlc2V0X3RzIEZST00gcGdfc3RhdF9yZWNvdmVyeV9wcmVmZXRjaCBc Z3NldAorLS0gVGVzdCB0aGF0IHJlc2V0X3NoYXJlZCB3aXRoIHNscnUgc3BlY2lmaWVkIGFzIHRo ZSBzdGF0cyB0eXBlIHdvcmtzCitTRUxFQ1QgTUFYKHN0YXRzX3Jlc2V0KSBBUyBzbHJ1X3Jlc2V0 X3RzIEZST00gcGdfc3RhdF9zbHJ1IFxnc2V0CitTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaGFyZWQo J3NscnUnKTsKKyBwZ19zdGF0X3Jlc2V0X3NoYXJlZCAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K KyAKKygxIHJvdykKKworU0VMRUNUIHN0YXRzX3Jlc2V0ID4gOidzbHJ1X3Jlc2V0X3RzJzo6dGlt ZXN0YW1wdHogRlJPTSBwZ19zdGF0X3NscnU7CisgP2NvbHVtbj8gCistLS0tLS0tLS0tCisgdAor IHQKKyB0CisgdAorIHQKKyB0CisgdAorIHQKKyg4IHJvd3MpCisKK1NFTEVDVCBNQVgoc3RhdHNf cmVzZXQpIEFTIHNscnVfcmVzZXRfdHMgRlJPTSBwZ19zdGF0X3NscnUgXGdzZXQKIC0tIFRlc3Qg dGhhdCByZXNldF9zaGFyZWQgd2l0aCB3YWwgc3BlY2lmaWVkIGFzIHRoZSBzdGF0cyB0eXBlIHdv cmtzCiBTRUxFQ1Qgc3RhdHNfcmVzZXQgQVMgd2FsX3Jlc2V0X3RzIEZST00gcGdfc3RhdF93YWwg XGdzZXQKIFNFTEVDVCBwZ19zdGF0X3Jlc2V0X3NoYXJlZCgnd2FsJyk7CkBAIC0xMDA3LDYgKzEw MjksMTkgQEAgU0VMRUNUIHN0YXRzX3Jlc2V0ID4gOidyZWNvdmVyeV9wcmVmZXRjaF9yZXNldF90 cyc6OnRpbWVzdGFtcHR6IEZST00gcGdfc3RhdF9yZWMKICB0CiAoMSByb3cpCiAKK1NFTEVDVCBz dGF0c19yZXNldCA+IDonc2xydV9yZXNldF90cyc6OnRpbWVzdGFtcHR6IEZST00gcGdfc3RhdF9z bHJ1OworID9jb2x1bW4/IAorLS0tLS0tLS0tLQorIHQKKyB0CisgdAorIHQKKyB0CisgdAorIHQK KyB0CisoOCByb3dzKQorCiBTRUxFQ1Qgc3RhdHNfcmVzZXQgPiA6J3dhbF9yZXNldF90cyc6OnRp bWVzdGFtcHR6IEZST00gcGdfc3RhdF93YWw7CiAgP2NvbHVtbj8gCiAtLS0tLS0tLS0tCkBAIC0x MDE2LDcgKzEwNTEsNyBAQCBTRUxFQ1Qgc3RhdHNfcmVzZXQgPiA6J3dhbF9yZXNldF90cyc6OnRp bWVzdGFtcHR6IEZST00gcGdfc3RhdF93YWw7CiAtLSBUZXN0IGVycm9yIGNhc2UgZm9yIHJlc2V0 X3NoYXJlZCB3aXRoIHVua25vd24gc3RhdHMgdHlwZQogU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2hh cmVkKCd1bmtub3duJyk7CiBFUlJPUjogIHVucmVjb2duaXplZCByZXNldCB0YXJnZXQ6ICJ1bmtu b3duIgotSElOVDogIFRhcmdldCBtdXN0IGJlICJhcmNoaXZlciIsICJiZ3dyaXRlciIsICJjaGVj a3BvaW50ZXIiLCAiaW8iLCAicmVjb3ZlcnlfcHJlZmV0Y2giLCBvciAid2FsIi4KK0hJTlQ6ICBU YXJnZXQgbXVzdCBiZSAiYXJjaGl2ZXIiLCAiYmd3cml0ZXIiLCAiY2hlY2twb2ludGVyIiwgImlv IiwgInJlY292ZXJ5X3ByZWZldGNoIiwgInNscnUiLCBvciAid2FsIi4KIC0tIFRlc3QgdGhhdCBy ZXNldCB3b3JrcyBmb3IgcGdfc3RhdF9kYXRhYmFzZQogLS0gU2luY2UgcGdfc3RhdF9kYXRhYmFz ZSBzdGF0c19yZXNldCBzdGFydHMgb3V0IGFzIE5VTEwsIHJlc2V0IGl0IG9uY2UgZmlyc3Qgc28g d2UgaGF2ZSBzb21ldGhpbmcgdG8gY29tcGFyZSBpdCB0bwogU0VMRUNUIHBnX3N0YXRfcmVzZXQo KTsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbCBiL3NyYy90ZXN0 L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbAppbmRleCBmZDhhZmVlYWU1Li5hZGQ0NjFlNWEwIDEwMDY0 NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9zdGF0cy5zcWwKKysrIGIvc3JjL3Rlc3QvcmVn cmVzcy9zcWwvc3RhdHMuc3FsCkBAIC00ODIsNiArNDgyLDEyIEBAIFNFTEVDVCBwZ19zdGF0X3Jl c2V0X3NoYXJlZCgncmVjb3ZlcnlfcHJlZmV0Y2gnKTsKIFNFTEVDVCBzdGF0c19yZXNldCA+IDon cmVjb3ZlcnlfcHJlZmV0Y2hfcmVzZXRfdHMnOjp0aW1lc3RhbXB0eiBGUk9NIHBnX3N0YXRfcmVj b3ZlcnlfcHJlZmV0Y2g7CiBTRUxFQ1Qgc3RhdHNfcmVzZXQgQVMgcmVjb3ZlcnlfcHJlZmV0Y2hf cmVzZXRfdHMgRlJPTSBwZ19zdGF0X3JlY292ZXJ5X3ByZWZldGNoIFxnc2V0CiAKKy0tIFRlc3Qg dGhhdCByZXNldF9zaGFyZWQgd2l0aCBzbHJ1IHNwZWNpZmllZCBhcyB0aGUgc3RhdHMgdHlwZSB3 b3JrcworU0VMRUNUIE1BWChzdGF0c19yZXNldCkgQVMgc2xydV9yZXNldF90cyBGUk9NIHBnX3N0 YXRfc2xydSBcZ3NldAorU0VMRUNUIHBnX3N0YXRfcmVzZXRfc2hhcmVkKCdzbHJ1Jyk7CitTRUxF Q1Qgc3RhdHNfcmVzZXQgPiA6J3NscnVfcmVzZXRfdHMnOjp0aW1lc3RhbXB0eiBGUk9NIHBnX3N0 YXRfc2xydTsKK1NFTEVDVCBNQVgoc3RhdHNfcmVzZXQpIEFTIHNscnVfcmVzZXRfdHMgRlJPTSBw Z19zdGF0X3NscnUgXGdzZXQKKwogLS0gVGVzdCB0aGF0IHJlc2V0X3NoYXJlZCB3aXRoIHdhbCBz cGVjaWZpZWQgYXMgdGhlIHN0YXRzIHR5cGUgd29ya3MKIFNFTEVDVCBzdGF0c19yZXNldCBBUyB3 YWxfcmVzZXRfdHMgRlJPTSBwZ19zdGF0X3dhbCBcZ3NldAogU0VMRUNUIHBnX3N0YXRfcmVzZXRf c2hhcmVkKCd3YWwnKTsKQEAgLTQ5NSw2ICs1MDEsNyBAQCBTRUxFQ1Qgc3RhdHNfcmVzZXQgPiA6 J2FyY2hpdmVyX3Jlc2V0X3RzJzo6dGltZXN0YW1wdHogRlJPTSBwZ19zdGF0X2FyY2hpdmVyOwog U0VMRUNUIHN0YXRzX3Jlc2V0ID4gOidiZ3dyaXRlcl9yZXNldF90cyc6OnRpbWVzdGFtcHR6IEZS T00gcGdfc3RhdF9iZ3dyaXRlcjsKIFNFTEVDVCBzdGF0c19yZXNldCA+IDonY2hlY2twb2ludGVy X3Jlc2V0X3RzJzo6dGltZXN0YW1wdHogRlJPTSBwZ19zdGF0X2NoZWNrcG9pbnRlcjsKIFNFTEVD VCBzdGF0c19yZXNldCA+IDoncmVjb3ZlcnlfcHJlZmV0Y2hfcmVzZXRfdHMnOjp0aW1lc3RhbXB0 eiBGUk9NIHBnX3N0YXRfcmVjb3ZlcnlfcHJlZmV0Y2g7CitTRUxFQ1Qgc3RhdHNfcmVzZXQgPiA6 J3NscnVfcmVzZXRfdHMnOjp0aW1lc3RhbXB0eiBGUk9NIHBnX3N0YXRfc2xydTsKIFNFTEVDVCBz dGF0c19yZXNldCA+IDond2FsX3Jlc2V0X3RzJzo6dGltZXN0YW1wdHogRlJPTSBwZ19zdGF0X3dh bDsKIAogLS0gVGVzdCBlcnJvciBjYXNlIGZvciByZXNldF9zaGFyZWQgd2l0aCB1bmtub3duIHN0 YXRzIHR5cGUKCmJhc2UtY29tbWl0OiBmMjZjMjM2OGRjYWVmNzUxOWQ4NDAwY2E5NThjNGI1NzQy Y2RiZDQ2Ci0tIAoyLjM5LjIKCg== --=_571d2c8ba3cbf2853d0ae6c817706653--