From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
cc: Kirk Wolak <wolakk@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql: Could we get "-- " prefixing on the **** QUERY ****
 outputs? (ECHO_HIDDEN)
In-reply-to: <b3b2ae6061c0d80fb29fe36482849e9171c3f659.camel@cybertec.at>
References: <20230515141457.ovpznndsvulahbpk@alvherre.pgsql>
 <2153025.1684160932@sss.pgh.pa.us>
 <CACLU5mSYSC-7waxNE0bsrph7QW9Bq9Dw5M26swmQ6x6iSd1tdQ@mail.gmail.com>
 <CACLU5mRhBiYjh-Cq7yvnGUA3VqX44Gh3QFkzmViP4ZNjdiJ7mw@mail.gmail.com>
 <b3b2ae6061c0d80fb29fe36482849e9171c3f659.camel@cybertec.at>
Comments: In-reply-to Laurenz Albe <laurenz.albe@cybertec.at>
	message dated "Wed, 17 May 2023 19:45:06 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3509102.1684347210.1@sss.pgh.pa.us>
Date: Wed, 17 May 2023 14:13:30 -0400
Message-ID: <3509103.1684347210@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3509103.1684347210%40sss.pgh.pa.us>
Precedence: bulk

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> You removed the ******** QUERY ******** at the end of the query.
> I think we should keep that (as comments, of course).  People
> are used to the current output, and it is nice to have a clear
> visual marker at the end of what isn't normally part of "psql"
> output.

I agree.  These considerations of what shows up in the readline
log if you choose to copy-and-paste seem far secondary to the
readability of the terminal output in the first place.

Also, you'd have to avoid copying-and-pasting the query output
anyway, so I'm not entirely sold that there's much of
a usability gain here.

			regards, tom lane