From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: "David E. Wheeler" <david@justatheory.com>,
        Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie,
        andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to
 pg_{clear,restore}_{attribute,relation}_stats()
In-reply-to: <aPZ_2a1EQvofxeci@nathan>
References: <78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>
 <CAOtk82QCHhWwO=zB-KFYch3JLf8Si4Bk77R_0cgsHjkwuhR9Vg@mail.gmail.com>
 <1957147.1760800489@sss.pgh.pa.us>
 <17DB0A6A-C967-48A8-B1C0-9A4F31C4F8EF@justatheory.com>
 <CAOtk82T=OO3e=SYPyHZq50wfyt569E6t=ee4b7va2y08M+a0SQ@mail.gmail.com>
 <F6567E02-23FD-455C-95D2-5CB076BC4E65@justatheory.com>
 <230647.1760971159@sss.pgh.pa.us> <aPZnY0Icgw1RGaGP@nathan>
 <334460.1760980024@sss.pgh.pa.us> <aPZt4b5beRPxjgI-@nathan>
 <aPZ_2a1EQvofxeci@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 20 Oct 2025 13:30:49 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <351025.1760988833.1@sss.pgh.pa.us>
Date: Mon, 20 Oct 2025 15:33:53 -0400
Message-ID: <351026.1760988833@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/351026.1760988833%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Here is an updated patch set.

The v3 patches work for me.

BTW, not critical right now, but thought I'd mention it: ISTM
this mechanism obviates the need for the single-purpose NodeTag ABI
checks installed by commit eea9fa9b2.  We still need the checks in
gen_node_support.pl to ensure that the makefiles and meson files
build things the same way, but we shouldn't need the parts that were
intended to prevent accidental ABI changes in the back branches.
Since that stuff requires nonzero manual maintenance, I plan to get
rid of it once we're satisfied that the ABI checker is working well.

			regards, tom lane