Message-ID: <3510716d-d3f3-40c8-9f7f-d644171acfb6@gmail.com>
Date: Wed, 3 Jan 2024 17:15:11 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
Content-Language: en-US
To: =?UTF-8?Q?C=C3=A9dric_Villemain?= <cedric.villemain+pgsql@abcsql.com>,
 Palak Chaturvedi <chaturvedipalak1911@gmail.com>,
 Nitin Jadhav <nitinjadhavpostgres@gmail.com>, pgsql-hackers@postgresql.org,
 Thomas Munro <thomas.munro@gmail.com>
References: <CALfch19pW48ZwWzUoRSpsaV9hqt0UPyaBPC4bOZ4W+c7FF566A@mail.gmail.com>
 <CAMm1aWbk-0C460G9ooy2yNSy1riecqvw4F7jPnqvToFZ_s4oGw@mail.gmail.com>
 <CALfch1890bL5SddyOpZDC8d-jZFOUGCGbOr+_11jLTwwJ_WEOA@mail.gmail.com>
 <CALfch1_s-X3wxeQbYxhXVuWZKBeY5YvU1D+nJxe21ri5iv0qrw@mail.gmail.com>
 <8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com>
From: Jim Nasby <jim.nasby@gmail.com>
In-Reply-To: <8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com>
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/3510716d-d3f3-40c8-9f7f-d644171acfb6%40gmail.com>
Precedence: bulk

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 1/3/24 10:25 AM, Cédric Villemain
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com">Hi
      Palak,
      <br>
      <br>
      I did a quick review of the patch:
      <br>
      <br>
      +CREATE FUNCTION pg_buffercache_invalidate(IN int, IN bool default
      true)
      <br>
      +RETURNS bool
      <br>
      +AS 'MODULE_PATHNAME', 'pg_buffercache_invalidate'
      <br>
      +LANGUAGE C PARALLEL SAFE;
      <br>
      <br>
      --&gt; Not enforced anywhere, but you can also add a comment to
      the function, for end users...
      <br>
    </blockquote>
    <p>The arguments should also have names...</p>
    <blockquote type="cite"
      cite="mid:8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com"><br>
      +    force = PG_GETARG_BOOL(1);
      <br>
      <br>
      I think you also need to test PG_ARGISNULL with force parameter.
      <br>
    </blockquote>
    Actually, that's true for the first argument as well. Or, just mark
    the function as STRICT.<br>
    <pre class="moz-signature" cols="72">-- 
Jim Nasby, Data Architect, Austin TX</pre>
  </body>
</html>