Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qokCU-002gnZ-5Y for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Oct 2023 12:45:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qokCQ-006i7B-IE for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Oct 2023 12:44:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qokCQ-006i71-7s for pgsql-hackers@lists.postgresql.org; Fri, 06 Oct 2023 12:44:59 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qokCM-000b5a-L2 for pgsql-hackers@postgresql.org; Fri, 06 Oct 2023 12:44:57 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 3651F617D1; Fri, 6 Oct 2023 21:44:48 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 06 Oct 2023 21:44:48 +0900 From: torikoshia To: Peter Eisentraut Cc: htamfids@gmail.com, Masahiro Ikeda , Pgsql Hackers Subject: Re: Make --help output fit within 80 columns per line In-Reply-To: <8decb0e3-6463-9eda-00dc-a05a3340b8bb@eisentraut.org> References: <50ca8ff35a8dd8f9ec89963b503571a7@oss.nttdata.com> <3965013067e7b6195132da6c0b80a609@oss.nttdata.com> <70043684388c1a8d181cf8f3308ad3ec@oss.nttdata.com> <7ab6295d479544ae9acb926dc3e556cf@oss.nttdata.com> <8decb0e3-6463-9eda-00dc-a05a3340b8bb@eisentraut.org> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <3514d73f84faaf5071c4580cdbd53e50@oss.nttdata.com> X-Sender: torikoshia@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-09-25 15:27, torikoshia wrote: > Ugh, regression tests failed and it appears to be due to reasons > related to meson. > I'm going to investigate it. ISTM On 2023-10-06 19:49, Peter Eisentraut wrote: > On 25.09.23 08:27, torikoshia wrote: >>> So in summary, I think 80 is a decent soft limit, but let's not >>> stress out about some lines going over that, and make a hard limit of >>> perhaps 120. >> >> +1. It may be a good compromise. >> For enforcing the hard limit, is it better to add a regression test >> like patch 0001? > >> Agreed. It seems inconsistent with other commands. >> Patch 0002 removed environment-variable-based defaults in psql --help. > > I have committed 0002 and a different implementation of 0001. I set > the maximum line length to 95, which is the current maximum in use. Thanks! BTW as far as I investigated, the original 0002 patch failed because current meson doesn't accept subtest outputs. As I commented below thread a few days ago, they once modified to accept subtest outputs, but not anymore. https://github.com/mesonbuild/meson/issues/10032 > I'm open to discussing other line lengths, but > > 1) If we make it longer, then we should also adjust the existing > wrapping so that we don't have a mix of lines wrapped at 80 and some > significantly longer lines. > > 2) There are some general readability guidelines that suggest like 66 > or 72 characters per line. If you take that and add the option name > itself and some indentation, then around 90 does seem like a sensible > limit. > > 3) The examples from other tools posted earlier don't convince me. > Some of their --help outputs look like junk and poorly taken care of. > > So I think nudging people to aim for 80..95 seems like a good target > right now. But I'm not against adjustments. -- Regards, -- Atsushi Torikoshi NTT DATA Group Corporation