From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Julien Rouhaud <rjuju123@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Robert Haas <robertmhaas@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        torikoshia <torikoshia@oss.nttdata.com>,
        Atsushi Torikoshi <atorik@gmail.com>,
        Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Evgeny Efimkin <efimkin@yandex-team.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
In-reply-to: <20210317151701.GA16650@momjian.us>
References: <20201018030142.GA4069@alvherre.pgsql>
 <157599.1602994837@sss.pgh.pa.us>
 <CAOBaU_bcsqYWzyABkh=i8X96DBychnVxQBvFo9wow-afMuECCA@mail.gmail.com>
 <CAOBaU_Y-AB8Z3-_pM0XQaoaYE07EouO8JxVOCJRq_QV3+uhqmA@mail.gmail.com>
 <CAOBaU_bpMCedwH4+40ybGoPeKNpg7cdQtMVLX1SaR0L2qfO=0Q@mail.gmail.com>
 <CAOBaU_YzqYgsSoxbgiUycCFNS_rVtLhnVOe8V52FpgzFn_ocPA@mail.gmail.com>
 <20210314080645.uk5gonqifgasdvo7@nol> <20210317151701.GA16650@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Wed, 17 Mar 2021 11:17:01 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3518600.1615994918.1@sss.pgh.pa.us>
Date: Wed, 17 Mar 2021 11:28:38 -0400
Message-ID: <3518601.1615994918@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3518601.1615994918%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> We are reaching the two-year mark on this feature, that everyone seems
> to agree is needed.  Is any committer going to work on this to get it
> into PG 14?  Should I take it?

I still say that it's a serious mistake to sanctify a query ID calculation
method that was designed only for pg_stat_statement's needs as the one
true way to do it.  But that's what exposing it in a core view would do.

			regards, tom lane