Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ncaeG-00084j-Fx
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 22:30:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ncaeE-0000mF-PN
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 22:30:38 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ncaeE-0000m6-Gk
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 22:30:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ncaeC-0007X4-LG
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 22:30:38 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 237MTrq03528728;
	Thu, 7 Apr 2022 18:29:53 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chapman Flack <chap@anastigmatix.net>
cc: pgsql-hackers@lists.postgresql.org, Mark Wong <markwkm@gmail.com>,
        Konstantina Skovola <konskov@gmail.com>
Subject: Re: trigger example for plsample
In-reply-to: 
 <164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org>
References: <Yd8Cz22eHi80XS30@workstation-mark-wong>
 <Yk8OFtSyKDLLhjPW@workstation-mark-wong>
 <164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org>
Comments: In-reply-to Chapman Flack <chap@anastigmatix.net>
	message dated "Thu, 07 Apr 2022 21:37:38 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3528726.1649370593.1@sss.pgh.pa.us>
Date: Thu, 07 Apr 2022 18:29:53 -0400
Message-ID: <3528727.1649370593@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3528727.1649370593%40sss.pgh.pa.us>
Precedence: bulk

Chapman Flack <chap@anastigmatix.net> writes:
> v4 looks good to me.

Pushed with very minor editorialization.  Mainly, I undid the
decision to stop printing the function source text, on the
grounds that (1) it falsified the comment immediately above,
and (2) if you have to print it anyway to avoid compiler warnings,
you're just creating confusing inconsistency between the two
handler functions.

			regards, tom lane