From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Robert Haas <robertmhaas@gmail.com>,
        Markus Wanner <markus.wanner@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if
 TRUNCATE overlaps a checkpoint.]
In-reply-to: <Yk94Hvnrx1V00skb@paquier.xyz>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
 <a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
 <CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
 <2358496.1649168259@sss.pgh.pa.us>
 <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
 <Yk94Hvnrx1V00skb@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 08 Apr 2022 08:47:42 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3535854.1649375539.1@sss.pgh.pa.us>
Date: Thu, 07 Apr 2022 19:52:19 -0400
Message-ID: <3535855.1649375539@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3535855.1649375539%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
>> Here are patches for master and v14 to do things this way. Comments?

> Thanks for the patches.  They look correct.  For ~14, I'd rather avoid
> the code duplication done by GetVirtualXIDsDelayingChkptEnd() and
> HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra
> bool argument to the existing routine.

Isn't adding another argument an API break?  (If there's any outside
code calling GetVirtualXIDsDelayingChkpt, which it seems like there
might be.)

			regards, tom lane