From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David E. Wheeler" <david@justatheory.com>
cc: jian he <jian.universality@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Document DateStyle effect on jsonpath string()
In-reply-to: <A556B643-F7E6-442D-9235-2D46A8A887C1@justatheory.com>
References: <56955B33-6959-4FDA-A459-F00363ECDFEE@justatheory.com> <CACJufxHREyTFzKOWz3f-yD14HxAdfeP1vGQQ2SQrusZ+ziRJyA@mail.gmail.com> <4D874C72-8939-4083-8336-AB114D9E29AD@justatheory.com> <CACJufxHE6q47-GEf3Kk0pD+Snr3yZMM4Byig2=bQKV8js7sP-A@mail.gmail.com> <B8E7081B-A8BE-4BAF-9C6B-AACD4F6EAB00@justatheory.com> <F492B399-37CB-471C-AEAD-25E1C19B607D@justatheory.com> <A556B643-F7E6-442D-9235-2D46A8A887C1@justatheory.com>
Comments: In-reply-to "David E. Wheeler" <david@justatheory.com>
	message dated "Tue, 30 Jul 2024 09:47:22 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3541397.1725994308.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Sep 2024 14:51:48 -0400
Message-ID: <3541398.1725994308@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3541398.1725994308%40sss.pgh.pa.us>
Precedence: bulk

"David E. Wheeler" <david@justatheory.com> writes:
> Rebase on 47c9803. I also changed the commitfest item[1] to =E2=80=9Crea=
dy for committer=E2=80=9D, since jian reviewed it, though I couldn=E2=80=99=
t see a way to add jian as a reviewer in the app. Hope that makes sense.

Pushed with a little additional polishing.

I thought the best way to address jian's complaint about DateStyle not
being clearly locked down was to change horology.sql to verify the
prevailing setting, as it has long done for TimeZone.  That's the
lead test script for related stuff, so it makes the most sense to
do it there.  Having done that, I don't feel a need to duplicate
that elsewhere.

			regards, tom lane