Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1so64x-008GrM-Nr
	for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 18:59:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1so63y-000XIs-D7
	for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 18:58:06 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1so63y-000XIP-19
	for pgsql-hackers@lists.postgresql.org; Tue, 10 Sep 2024 18:58:06 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1so63v-000Vbo-0L
	for pgsql-hackers@lists.postgresql.org; Tue, 10 Sep 2024 18:58:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 48AIvt4R3542371;
	Tue, 10 Sep 2024 14:57:55 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
cc: Noah Misch <noah@leadboat.com>, Joe Conway <mail@joeconway.com>,
        Peter Eisentraut <peter@eisentraut.org>,
        Alexander Korotkov <aekorotkov@gmail.com>,
        "Guo,
    Adam" <adamguo@amazon.com>,
        "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Jim Mlodgenski <jimmy76@gmail.com>
Subject: Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation
In-reply-to: <CAD21AoDGs0F8hu9sk0JHMk32FSJ1rzy9HUfivYhd4O0r=6QGHg@mail.gmail.com>
References: <1696557.1714498172@sss.pgh.pa.us> <c15efbd9-fb92-4e72-8ffa-20dccf5515ad@eisentraut.org> <2652929.1714745623@sss.pgh.pa.us> <3846ef0f-5273-41aa-a77e-f92841e0515f@eisentraut.org> <362570f3-1031-4f8e-a077-81c103200b64@joeconway.com> <CAD21AoDJEKZO_=szRtOTX6we6wC_wWsHXH1zcEqza2vHE-YW4Q@mail.gmail.com> <20240518214546.e8@rfd.leadboat.com> <CAD21AoBO-iL=UgHKQrKE=7zBrMYR_fAhLb8AGo_kmNgmkPKuQA@mail.gmail.com> <20240831031038.31.nmisch@google.com> <CAD21AoC=7oF29N6iKaTssn-rRGnoTVSLzTQh4ia4ZUO1iKKc_w@mail.gmail.com> <20240906215937.f7.nmisch@google.com> <2385726.1725662213@sss.pgh.pa.us> <CAD21AoCFxA0F+KqsVGLMYME7iW6KdVwvAU9YyieULa92zZx=zg@mail.gmail.com> <3317883.1725925337@sss.pgh.pa.us> <CAD21AoA3qDyzbiq6+ELT9at=JsW5br5saTHBwY0SCUDS_qfnEQ@mail.gmail.com> <3364732.1725949535@sss.pgh.pa.us> <CAD21AoDGs0F8hu9sk0JHMk32FSJ1rzy9HUfivYhd4O0r=6QGHg@mail.gmail.com>
Comments: In-reply-to Masahiko Sawada <sawada.mshk@gmail.com>
	message dated "Tue, 10 Sep 2024 11:31:46 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3542369.1725994675.1@sss.pgh.pa.us>
Date: Tue, 10 Sep 2024 14:57:55 -0400
Message-ID: <3542370.1725994675@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/3542370.1725994675%40sss.pgh.pa.us>
Precedence: bulk

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> An alternative way would be that we store the char signedness in the
> control file, and gin_trgm_ops opclass reads it if the bytes in the
> meta page shows 'unset'. The char signedness in the control file
> doesn't mean to be used for the compatibility check for physical
> replication but used as a hint. But it also could be a bit messy,
> though.

Yeah, that seems like it could work.  But are we sure that replicas
get a copy of the primary's control file rather than creating their
own?

			regards, tom lane