To: gkokolatos@pm.me
Cc: Michael Paquier <michael@paquier.xyz>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <07BK3Mk5aEOsTwGaY77qBVyf9GjoEzn8TMgHLyPGfEFPIpTEmoQuP2P4c7teesjSg-LPeUafsp1flnPeQYINMSMB_UpggJDoduB5EDYBqaQ=@protonmail.com>
 <YOvkR0F6i4AmmmUe@paquier.xyz>
 <qQjgSaFwOzw7iFfsrbo4dRn_AbfxhEl7kXpEXvsIrljGCkoocIcI_2N8vbcE85-6BgKF_C5rYPW8ZH_STh9UCmweG5kEboj64LOjElPOYRc=@pm.me>
 <Z2HZM9UW1iBmdHa8CmqW7YkHHAcOhUiWxZjBkEq3BJxKRW-S87bITtp9c2l-Al1IMoCNRXOmal3nH22UirhD0HKTVcLkWv__oVc4mXmHOoM=@pm.me>
 <AS-DklS9IbOb20QxukKOm4CjIYxptH5TpiJyiKF0zzW9wARr_PYFPFvqGPj-R-3LwcLGXGIIr4bvTXYQ1YCpR0B-y7SyQhn9yvFQZC6ldgA=@pm.me>
From: Gilles Darold <gilles@darold.net>
Subject: Re: Introduce pg_receivewal gzip compression tests
Message-ID: <3543bfcd-e07e-129e-ff3c-5daf99aa182a@darold.net>
Date: Mon, 12 Jul 2021 13:00:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: 
 <AS-DklS9IbOb20QxukKOm4CjIYxptH5TpiJyiKF0zzW9wARr_PYFPFvqGPj-R-3LwcLGXGIIr4bvTXYQ1YCpR0B-y7SyQhn9yvFQZC6ldgA=@pm.me>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/3543bfcd-e07e-129e-ff3c-5daf99aa182a%40darold.net>
Precedence: bulk

Le 12/07/2021 =C3=A0 12:27, gkokolatos@pm.me a =C3=A9crit=C2=A0:
>>>>
>>>> Shouldn't this be coded as a loop going through @gzip_wals?
>>> I would hope that there is only one gz file created. There is a line
>>>
>>> further up that tests exactly that.
>>>
>>> -   is (scalar(@gzip_wals), 1, "one gzip compressed WAL was created")=
;
>> Let me amend that. The line should be instead:
>>
>> is (scalar(keys @gzip_wals), 1, "one gzip compressed WAL was created")=
;
>>
>> To properly test that there is one entry.
>>
>> Let me provide with v2 to fix this.


The following tests are not correct in Perl even if Perl returns the
right value.

+=C2=A0=C2=A0=C2=A0 is (scalar(keys @gzip_wals), 1, "one gzip compressed =
WAL was created");


+=C2=A0=C2=A0=C2=A0 is (scalar(keys @gzip_partial_wals), 1,
+=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "one partial gzip compressed WAL w=
as created");


Function keys or values are used only with hashes but here you are using
arrays. To obtain the length of the array you can just use the scalar
function as Perl returns the length of the array when it is called in a
scalar context. Please use the following instead:


+=C2=A0=C2=A0=C2=A0 is (scalar(@gzip_wals), 1, "one gzip compressed WAL w=
as created");


+=C2=A0=C2=A0=C2=A0 is (scalar(@gzip_partial_wals), 1,
+=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "one partial gzip compressed WAL w=
as created");


--=20
Gilles Darold
http://www.darold.net/