Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1mIbAg-0006Rm-NL
	for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Aug 2021 18:29:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1mIbAf-0000Jt-ME
	for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Aug 2021 18:29:13 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1mIbAf-0000Jk-Ei
	for pgsql-hackers@lists.postgresql.org; Tue, 24 Aug 2021 18:29:13 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1mIbAd-0002eS-BR
	for pgsql-hackers@lists.postgresql.org; Tue, 24 Aug 2021 18:29:12 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 17OIT1Kf354914;
	Tue, 24 Aug 2021 14:29:01 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Andrew Dunstan <andrew@dunslane.net>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Joel Jacobson <joel@compiler.org>
Subject: Re: Another regexp performance improvement: skip useless
 paren-captures
In-reply-to: <51ED454F-0F52-4D66-8117-1DB0363240DF@enterprisedb.com>
References: <2219936.1628115334@sss.pgh.pa.us>
 <31908a04-f73b-8c5b-ed99-919fd4cd4b54@dunslane.net>
 <2390507.1628174181@sss.pgh.pa.us>
 <2BFE7DFD-8537-4B4E-BC4C-2F265A836651@enterprisedb.com>
 <3173384.1628442278@sss.pgh.pa.us>
 <BDB634FD-2EE5-4697-91A0-1F53E1363D3B@enterprisedb.com>
 <3224306.1628454300@sss.pgh.pa.us>
 <D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com>
 <3289730.1628461693@sss.pgh.pa.us>
 <B323249F-B221-4DCE-8763-E5070A77452E@enterprisedb.com>
 <3534632.1628536485@sss.pgh.pa.us>
 <A099E4A8-4377-4C64-A98C-3DEDDC075502@enterprisedb.com>
 <3643732.1628551901@sss.pgh.pa.us>
 <1303A200-4615-4559-961A-CC906DE07EAF@enterprisedb.com>
 <3756810.1628562033@sss.pgh.pa.us>
 <51ED454F-0F52-4D66-8117-1DB0363240DF@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Tue, 24 Aug 2021 10:02:13 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <354912.1629829741.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 24 Aug 2021 14:29:01 -0400
Message-ID: <354913.1629829741@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/354913.1629829741%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I've beaten on this with random patterns and it seems to hold up just fi=
ne.  I have also reviewed the diffs and, for the patterns where the output=
 changes, everything looks correct.  I can't find anything wrong with this=
 patch.

Thanks for testing!  I'll push it in a bit.

			regards, tom lane