From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Andres Freund <andres@anarazel.de>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?
In-reply-to: <DCA2CD4A-E99F-4120-AE96-F510D994FE89@yesql.se>
References: <20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de> <20230823065833.vnnfwoi3n2sbw5kf@awork3.anarazel.de> <CF26F682-EA8E-485C-A682-E06A7D3D8D37@yesql.se> <20230823192239.jxew5s3sjru63lio@awork3.anarazel.de> <DCA2CD4A-E99F-4120-AE96-F510D994FE89@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 23 Aug 2023 22:11:09 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3557215.1692824571.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Aug 2023 17:02:51 -0400
Message-ID: <3557216.1692824571@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3557216.1692824571%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 23 Aug 2023, at 21:22, Andres Freund <andres@anarazel.de> wrote:
>> I think there's more effective ways to make this cheaper. The basic thi=
ng
>> would be to use libpq instead of forking of psql to make a connection
>> check.

> I had it in my head that not using libpq in pg_regress was a deliberate =
choice,
> but I fail to find a reference to it in the archives.

I have a vague feeling that you are right about that.  Perhaps the
concern was that under "make installcheck", pg_regress might be
using a build-tree copy of libpq rather than the one from the
system under test.  As long as we're just trying to ping the server,
that shouldn't matter too much I think ... unless we hit problems
with, say, a different default port number or socket path compiled into
one copy vs. the other?  That seems like it's probably a "so don't
do that" case, though.

			regards, tom lane