MIME-Version: 1.0
Date: Sat, 17 Sep 2022 11:42:24 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@postgresql.org, pryzby@telsasoft.com, rjuju123@gmail.com,
 daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz
Subject: Re: ICU for global collation
In-Reply-To: <26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com>
References: <1f86f120-7b02-68f6-a434-132d054afe33@enterprisedb.com>
 <38d2aac40a991b20adf032e509c6eff5@postgrespro.ru>
 <6dd6db0984d86a51b7255ba79f111971@postgrespro.ru>
 <20220915.155210.529619933474389138.horikyota.ntt@gmail.com>
 <2322791a368e9ad066edd648790b5e91@postgrespro.ru>
 <26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <355a424f234f849c2515b9c4076feff0@postgrespro.ru>
Organization: Postgres Professional
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/355a424f234f849c2515b9c4076feff0%40postgrespro.ru>
Precedence: bulk

On 2022-09-16 10:56, Peter Eisentraut wrote:
> On 15.09.22 17:41, Marina Polyakova wrote:
>> I agree with you. Here's another version of the patch. The 
>> locale/encoding checks and reports in initdb have been reordered, 
>> because now the encoding is set first and only then the ICU locale is 
>> checked.
> 
> I committed something based on the first version of your patch.  This
> reordering of the messages here was a little too much surgery for me
> at this point.  For instance, there are also messages in #ifdef WIN32
> code that would need to be reordered as well.  I kept the overall
> structure of the code the same and just inserted the additional
> proposed checks.
> 
> If you want to pursue the reordering of the checks and messages
> overall, a patch for the master branch could be considered.

Thank you! I already wrote about the order of the ICU checks in 
initdb/create database, they were the only reason to propose such 
changes...

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company