From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Amit Langote <amitlangote09@gmail.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS
In-reply-to: <YKWlmcsjR2zMRa+3@paquier.xyz>
References: <3382681.1621381328@sss.pgh.pa.us> <YKSAFhtltIr9GUEi@paquier.xyz>
 <3392911.1621395985@sss.pgh.pa.us> <YKSSj5yQOg1twolW@paquier.xyz>
 <CAA4eK1L_vVJyy_hAdNCzsFXYcdZ=UO_9UrYX=+GZeb4CBeLJ1Q@mail.gmail.com>
 <YKSciAJEPQ7wmNDt@paquier.xyz>
 <CA+HiwqEW7kVF+VKdHT7TnzQGab9-dP9tLyedVvs5nQ7yJ_BP6g@mail.gmail.com>
 <3508426.1621455835@sss.pgh.pa.us> <YKWlmcsjR2zMRa+3@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 20 May 2021 08:56:09 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3566940.1621471774.1@sss.pgh.pa.us>
Date: Wed, 19 May 2021 20:49:34 -0400
Message-ID: <3566941.1621471774@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3566941.1621471774%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, May 19, 2021 at 04:23:55PM -0400, Tom Lane wrote:
>> * Replace the edata->resultRelInfo field with two fields, one for
>> the original parent and one for the actual/current target.  Perhaps
>> this is worth doing, not sure.

> This one sounds more natural to me, though.

OK, I'll give that a try tomorrow.

> May I ask why you are not moving the snapshot pop and push into the
> finish() and create() routines for this patch?

That does need to happen, but I figured I'd leave it to the other
patch, since there are other things to change too for that snapshot
problem.  Obviously, whichever patch goes in second will need trivial
adjustments, but I think it's logically clearer that way.

> Also, any thoughts
> about adding the trigger tests from 013_partition.pl to REL_13_STABLE?

Yeah, if this is a pre-existing problem then we should back-port the
tests that revealed it.

			regards, tom lane