From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Daniel Gustafsson <daniel@yesql.se>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?
In-reply-to: <20230823220612.sglm5g5oxblunst3@awork3.anarazel.de>
References: <20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de> <20230823065833.vnnfwoi3n2sbw5kf@awork3.anarazel.de> <CF26F682-EA8E-485C-A682-E06A7D3D8D37@yesql.se> <20230823192239.jxew5s3sjru63lio@awork3.anarazel.de> <DCA2CD4A-E99F-4120-AE96-F510D994FE89@yesql.se> <3557216.1692824571@sss.pgh.pa.us> <20230823214341.stppgfnhrhmb6igf@awork3.anarazel.de> <3565659.1692827753@sss.pgh.pa.us> <20230823220612.sglm5g5oxblunst3@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 23 Aug 2023 15:06:12 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3570609.1692829946.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Aug 2023 18:32:26 -0400
Message-ID: <3570610.1692829946@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3570610.1692829946%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-08-23 17:55:53 -0400, Tom Lane wrote:
>> The trouble with that approach is that in "make installcheck", we
>> don't really want to assume we know what the installed libpq's default
>> connection parameters are.  So we don't explicitly know where that
>> libpq will connect.

> Stepping back: I don't think installcheck matters for the concrete use o=
f
> libpq we're discussing - the only time we wait for server startup is the
> non-installcheck case.

Oh, that's an excellent point.  So for the immediately proposed use-case,
there's no issue.  (We don't have a mode where we try to start a server
using already-installed executables.)

> There are other potential uses for libpq in pg_regress though - I'd e.g.=
 like
> to have a "monitoring" session open, which we could use to detect that t=
he
> server crashed (by waiting for the FD to be become invalid). Where the
> connection default issue could matter more?

Meh.  I don't find that idea compelling enough to justify adding
restrictions on what test scenarios will work.  It's seldom hard to
tell from the test output whether the server crashed.

> I was wondering if we could create an unambiguous connection info, but t=
hat
> seems like it'd be hard to do, without creating cross version hazards.

Hmm, we don't expect the regression test suite to work against other
server versions, so maybe that could be made to work --- that is, we
could run the psql under test and get a full set of connection
parameters out of it?  But I'm still not finding this worth the
trouble.

> What's the reason we don't force psql to come from the same build as
> pg_regress?

Because the point of installcheck is to check the installed binaries
--- including the installed psql and libpq.

(Thinks for a bit...)  Maybe we should add pg_regress to the installed
fileset, and use that copy not the in-tree copy for installcheck?
Then we could assume it's using the same libpq as psql.  IIRC there
have already been suggestions to do that for the benefit of PGXS
testing.

			regards, tom lane