From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas@vondra.me>
cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
        Michael Paquier <michael@paquier.xyz>,
        Andrew Dunstan <andrew@dunslane.net>, Amul Sul <sulamul@gmail.com>,
        Zsolt Parragi <zsolt.parragi@percona.com>,
        Robert Haas <robertmhaas@gmail.com>, Chao Li <li.evan.chao@gmail.com>,
        Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
        Fujii Masao <masao.fujii@gmail.com>,
        Jakub Wartak <jakub.wartak@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
In-reply-to: <02770bea-b3f3-4015-8a43-443ae345379c@vondra.me>
References: <2250061.1774104346@sss.pgh.pa.us>
 <CAD5tBcLsYDz+Nzx8MryjxiKaN3fGKd4ZgXuN1Jn=CYxw9dh+AA@mail.gmail.com>
 <3341199.1774221191@sss.pgh.pa.us> <3424809.1774234940@sss.pgh.pa.us>
 <acIA8KKBTv-T53YG@paquier.xyz>
 <x2tknjejjouleunkqrvpnwn2tuulunybinycidefm3wmnsyhht@pw5uo3wrqx43>
 <CA+hUKGL2dppjO4o28ZY7n_LTWviKLAi-7KZ=tx5w2HGevCEYPA@mail.gmail.com>
 <1624716.1774736283@sss.pgh.pa.us> <1626907.1774737417@sss.pgh.pa.us>
 <97a382c0-1f19-4ea0-951f-e37e6abc34a3@vondra.me>
 <1630755.1774739531@sss.pgh.pa.us>
 <c3a2b730-9d90-4a66-ae5e-50f6d77922d6@vondra.me>
 <CA+hUKGJyvdyWMC-RW1njqevD-q_gTbFq+DyDiFpUJVaG+DY20w@mail.gmail.com>
 <1873141.1774823011@sss.pgh.pa.us>
 <CA+hUKG+Pqz5=YQG_=8ho0YsTfn2HWOsJQWqS4j0q8QQWweJP9w@mail.gmail.com>
 <3049460.1775067940@sss.pgh.pa.us> <CA+hUKGJv2hpjM!
 DwG31JSR7TfFUxNPPtQKMm6mHVVRMAT0XppBQ@mail.gmail.com>
 <3118179.1775092964@sss.pgh.pa.us>
 <CA+hUKG+-pn14s_tjEBO6YKHmc=uRhGVn=w2oM91KKnEUc7pH0Q@mail.gmail.com>
 <3565835.1775147392@sss.pgh.pa.us> <02770bea-b3f3-4!
 015-8a43-443ae345379c@vondra.me>
Comments: In-reply-to Tomas Vondra <tomas@vondra.me>
	message dated "Thu, 02 Apr 2026 19:13:08 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3579708.1775151816.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 02 Apr 2026 13:43:36 -0400
Message-ID: <3579709.1775151816@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3579709.1775151816%40sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas@vondra.me> writes:
> On 4/2/26 18:29, Tom Lane wrote:
>> Pushed, thanks for reviewing!  In the event I decided to back-patch to
>> v18, where these fixes could protect pg_verifybackup against tar files
>> it can't handle.

> It seems jay/hippopotamus failed on this, for some reason.

Hmm:

#   Failed test 'corrupt backup fails verification: extra_file: matches'
#   at t/003_corruption.pl line 198.
#                   'pg_verifybackup: error: pax extensions to tar format =
are not supported
# '
#     doesn't match '(?^:extra_file.*present (on disk|in archive "[^"]+") =
but not in the manifest)'

> Maybe there's something special about OpenSUSE?

Apparently its version of "tar" will produce pax-extended files
at the drop of a hat.  I have an OpenSUSE image around here
somewhere, will see if I can reproduce this.  But while I'm
asking, what filesystem are those animals running on top of?

			regards, tom lane