Feedback-ID: i131946ab:Fastmail
Message-ID: <357fec80-cb54-1455-0632-b23d844e5a68@enterprisedb.com>
Date: Wed, 31 Aug 2022 11:35:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Content-Language: en-US
To: Christoph Berg <myon@debian.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/357fec80-cb54-1455-0632-b23d844e5a68%40enterprisedb.com>
Precedence: bulk

On 30.08.22 15:16, Christoph Berg wrote:
> I found the list of TG_ variables on
> https://www.postgresql.org/docs/current/plpgsql-trigger.html#PLPGSQL-DML-TRIGGER
> hard to read for several reasons: too much whitespace, all the lines
> start with "Data type", and even after that, the actual content is
> hiding behind some extra "variable that..." boilerplate.
> 
> The attached patch formats the list as a table, and removes some of
> the clutter from the text.
> 
> I reused the catalog_table_entry table machinery, that is probably not
> quite the correct thing, but I didn't find a better variant, and the
> result looks ok.

I find the new version even harder to read.  The catalog_table_entry 
stuff doesn't really make sense here, since what you have before is 
already a definition list, and afterwards you have the same, just marked 
up "incorrectly".

We could move the data type in the <term>, similar to how you did it in 
your patch.

I agree the whitespace layout is weird, but that's a problem of the 
website CSS stylesheet.  I think it looks a bit better with the local 
stylesheet, but that can all be tweaked.