From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
In-reply-to: <561ffd5c-3332-abb9-3e60-17b41f025a6b@dunslane.net>
References: <3395418.1618352794@sss.pgh.pa.us>
 <20210414020827.GA1232417@rfd.leadboat.com>
 <3441172.1618369873@sss.pgh.pa.us>
 <20210414125811.GB1263822@rfd.leadboat.com>
 <CA+TgmoaF_DKSPRnbkakkOufWMFpOBsA8fwE-mF0fF7aeH20zqg@mail.gmail.com>
 <3489827.1618411777@sss.pgh.pa.us>
 <CA+TgmoYQB1qxb=v9xVi09-f_HRDDqwUwfcuNpsZ2SF-ePpWJcw@mail.gmail.com>
 <3566011.1618422104@sss.pgh.pa.us>
 <CA+TgmobdzZc2UET6z_=e_Uia63Btb3jMX2bVSukWvE21y75o-g@mail.gmail.com>
 <3567049.1618423436@sss.pgh.pa.us>
 <561ffd5c-3332-abb9-3e60-17b41f025a6b@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 14 Apr 2021 15:32:28 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3583531.1618431192.1@sss.pgh.pa.us>
Date: Wed, 14 Apr 2021 16:13:12 -0400
Message-ID: <3583532.1618431192@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3583532.1618431192%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 4/14/21 2:03 PM, Tom Lane wrote:
>> This may mean that squeezing these contrib changes into v14 is a lost
>> cause.  We certainly shouldn't try to do what I suggest above for
>> v14; but without it, these changes are just moving the security
>> issue to a different place rather than eradicating it completely.

> Is there anything else we should be doing along the eat your own dogfood
> line that don't have these security implications?

We can still convert the initdb-created SQL functions to new style,
since there's no security threat during initdb.  I'll make a patch
for that soon.

			regards, tom lane