public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Andrew Dunstan <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Wed, 17 May 2023 17:10:48 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
<[email protected]>
<OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<[email protected]>
<CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAGECzQQH35856o4LsOF5kBAEwna_ONBcarCFcShwbh1yhXAa_w@mail.gmail.com>
<ef2edec2-e55e-a751-a90f-5929b! [email protected]>
<[email protected]! gh.pa.us>
<[email protected]>
<[email protected]>
<341b0011-1190-288b! ! [email protected]>
<[email protected]>
I wrote:
> Andrew Dunstan <[email protected]> writes:
>> I doubt there's something like that.
> I had a read-through of the latest version's man page, and found
> this promising-looking entry:
> -boc, --break-at-old-comma-breakpoints
Sadly, this seems completely not ready for prime time. I experimented
with it under perltidy 20230309, and found that it caused hundreds
of kilobytes of gratuitous changes that don't seem to have a direct
connection to the claimed purpose. Most of these seemed to be from
forcing a line break after a function call's open paren, like
@@ -50,10 +50,12 @@ detects_heap_corruption(
#
fresh_test_table('test');
$node->safe_psql('postgres', q(VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) test));
-detects_no_corruption("verify_heapam('test')",
+detects_no_corruption(
+ "verify_heapam('test')",
"all-frozen not corrupted table");
corrupt_first_page('test');
-detects_heap_corruption("verify_heapam('test')",
+detects_heap_corruption(
+ "verify_heapam('test')",
"all-frozen corrupted table");
detects_no_corruption(
"verify_heapam('test', skip := 'all-frozen')",
although in some places it just wanted to insert a space, like this:
@@ -77,9 +81,9 @@ print "standby 2: $result\n";
is($result, qq(33|0|t), 'check streamed sequence content on standby 2');
# Check that only READ-only queries can run on standbys
-is($node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
+is( $node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
3, 'read-only queries on standby 1');
-is($node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
+is( $node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
3, 'read-only queries on standby 2');
# Tests for connection parameter target_session_attrs
So I don't think we want that. Maybe in some future version it'll
be more under control.
Barring objections, I'll use the attached on Friday.
regards, tom lane
Attachments:
[text/x-diff] v1-perltidy-option-changes.patch (1.7K, ../[email protected]/2-v1-perltidy-option-changes.patch)
download | inline diff:
commit 7874d0f178f2bcdc889ce410d3e126e6750d96b4
Author: Tom Lane <[email protected]>
Date: Wed May 17 16:43:38 2023 -0400
Make agreed updates in perltidy options.
Discussion: https://postgr.es/m/[email protected]
diff --git a/src/tools/pgindent/README b/src/tools/pgindent/README
index 43c736b0a1..08874d12eb 100644
--- a/src/tools/pgindent/README
+++ b/src/tools/pgindent/README
@@ -14,16 +14,16 @@ PREREQUISITES:
sibling directory src/tools/pg_bsd_indent; see the directions
in that directory's README file.
-2) Install perltidy. Please be sure it is version 20170521 (older and newer
+2) Install perltidy. Please be sure it is version 20230309 (older and newer
versions make different formatting choices, and we want consistency).
You can get the correct version from
https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/
To install, follow the usual install process for a Perl module
("man perlmodinstall" explains it). Or, if you have cpan installed,
this should work:
- cpan SHANCOCK/Perl-Tidy-20170521.tar.gz
+ cpan SHANCOCK/Perl-Tidy-20230309.tar.gz
Or if you have cpanm installed, you can just use:
- cpanm https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/Perl-Tidy-20170521.tar.gz
+ cpanm https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/Perl-Tidy-20230309.tar.gz
DOING THE INDENT RUN:
diff --git a/src/tools/pgindent/perltidyrc b/src/tools/pgindent/perltidyrc
index 9f09f0a64e..589d6e1f06 100644
--- a/src/tools/pgindent/perltidyrc
+++ b/src/tools/pgindent/perltidyrc
@@ -14,3 +14,4 @@
--paren-vertical-tightness=2
--paren-vertical-tightness-closing=2
--noblanks-before-comments
+--valign-exclusion-list=", = => =~ |= || && if or qw unless"
view thread (142+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox