public inbox for [email protected]
help / color / mirror / Atom feedFrom: Li Japin <[email protected]>
To: Surafel Temesgen <[email protected]>
Cc: Vik Fearing <[email protected]>
Cc: Simon Riggs <[email protected]>
Cc: Ryan Lambert <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Rémi Lapeyre <[email protected]>
Cc: Eli Marmor <[email protected]>
Cc: David Steele <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Georgios <[email protected]>
Subject: Re: WIP: System Versioned Temporal Table
Date: Thu, 25 Feb 2021 10:28:28 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALAY4q-4YpPc=hSGpxCJBVwpTKzm2A5JyoXUr+2Lh0KTiUcjPQ@mail.gmail.com>
References: <[email protected]>
<CALAY4q_LCeyMj2KPq2aA5f3L-fPF-kP_w1nuwjZJkrop-o_w=Q@mail.gmail.com>
<CAN-V+g_ZpK7cbx7szKV8Ma6sNNGy4d34sGh5FMy14h68F8gjBQ@mail.gmail.com>
<CALAY4q-JMDqW5=LH6f70WhiO1+tP2NhGbWv_fjPtOt=KezchUQ@mail.gmail.com>
<CAD21AoAUDJj_y_5fH5FLBLUDTZa579jbE5Y12SQz4nJh-RVx7A@mail.gmail.com>
<CANbhV-EZu-SHXERZ=Bbq5g+ePi7QUX_0WgLtRsove_Jiigtaaw@mail.gmail.com>
<CANbhV-EOTSc2EWS_LKiXKgLqnrjtaU0hf3Rzxn111nir6Pn4zA@mail.gmail.com>
<CANbhV-ECkPhsXEtj7gYFjXCdq+3WTiHo9XkF5wQmFOj4w+YTaw@mail.gmail.com>
<CANbhV-Fb35HMoySGMFfcxN_3i45Bb6cZODOcz8S7+Nys3Y2raA@mail.gmail.com>
<CAN-V+g-D7bObC3m5rcm3zr8MmTVE4_OVJuEp8Qse0ZgE4PAhsw@mail.gmail.com>
<CANbhV-F3S=5+5w19cowPwewBXSV3+C5T3BD327KQD7BLFgZbCQ@mail.gmail.com>
<CAN-V+g_7EC=kAVeQV=+XL+KoV=QLdx_79J55OBarEYd49_uHRA@mail.gmail.com>
<CANbhV-H-Wt7TVEwzzaYNEZ8-OteipdtvsxN1Qr1G9XpZoX2GgA@mail.gmail.com>
<CANbhV-EymXWOFdX-Sz7PqQ8kphqHMteErBgD=FxmE+uF7jVW4w@mail.gmail.com>
<[email protected]>
<CALAY4q-4YpPc=hSGpxCJBVwpTKzm2A5JyoXUr+2Lh0KTiUcjPQ@mail.gmail.com>
On Jan 27, 2021, at 12:39 AM, Surafel Temesgen <[email protected]<mailto:[email protected]>> wrote:
On Tue, Jan 26, 2021 at 2:33 PM Vik Fearing <[email protected]<mailto:[email protected]>> wrote:
I'm still in the weeds of reviewing this patch, but why should this
fail? It should not fail.
Attached is rebased patch that include isolation test
Thanks for updating the patch. However it cannot apply to master (e5d8a9990).
Here are some comments on system-versioning-temporal-table_2021_v13.patch.
+</programlisting>
+ When system versioning is specified two columns are added which
+ record the start timestamp and end timestamp of each row verson.
verson -> version
+ By default, the column names will be StartTime and EndTime, though
+ you can specify different names if you choose.
In fact, it is start_time and end_time, not StartTime and EndTime.
I think it's better to use <literal> label around start_time and end_time.
+ column will be automatically added to the Primary Key of the
+ table.
Should we mention the unique constraints?
+ The system versioning period end column will be added to the
+ Primary Key of the table as a way of ensuring that concurrent
+ INSERTs conflict correctly.
Same as above.
Since the get_row_start_time_col_name() and get_row_end_time_col_name()
are similar, IMO we can pass a flag to get StartTime/EndTime column name,
thought?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
view thread (97+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: WIP: System Versioned Temporal Table
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox