From: Nikolay Shaplov <dhyan@nataraj.su>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>
Subject: Re: [PATCH] Tests for reloptions
Date: Sun, 29 Oct 2017 17:08:29 +0300
Message-ID: <35939314.PpRHriQSIJ@x200m>
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <20171019122052.f3cychhfktrfwqdk@alvherre.pgsql>
References: <20171019122052.f3cychhfktrfwqdk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart1828944.xiG0zkXFMd"
Content-Transfer-Encoding: 7Bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

This is a multi-part message in MIME format.

--nextPart1828944.xiG0zkXFMd
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

=D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 19 =D0=BE=D0=BA=D1=
=82=D1=8F=D0=B1=D1=80=D1=8F 2017 14:20:52 =D0=92=D1=8B =D0=BD=D0=B0=D0=BF=
=D0=B8=D1=81=D0=B0=D0=BB=D0=B8:

> Yeah, it would perhaps be good idea to ensure we don't break things that
> are documented to work.  If the tests don't take too long, I'm not
> opposed to testing every single option.  As you say, code coverage is
> important but it's not the only goal.
>=20
> I'm hesitant to hardcode things like the number of bits in bloom, as you
> had in the original.  If I understand correctly, that number could
> change with compile options (different blocksize?), so I removed that
> part.  I also fixed a few spelling errors.
>=20
> And pushed.  Let's see what the buildfarm says about this.
While merging this commit to my branch, I found two issues that as I think=
=20
needs fixing. Hope this does not require creating new commit request...

First is missing tab.

Second i think it is better to write "The OIDS option is not stored as=20
_reloption_" otherwise it cat be read as if it is not stored at all.

See patch in the attachment.

Thank you again for your work with the patch. I've seen how much you have=20
change it.

PS do I get right that 80 character code width rule is applied to SQL tests=
=20
too?

--=20
Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)=

--nextPart1828944.xiG0zkXFMd
Content-Disposition: attachment; filename="reloptions.sql.diff"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="reloptions.sql.diff"

diff --git a/src/test/regress/sql/reloptions.sql b/src/test/regress/sql/reloptions.sql
index c9119fd..21a315b 100644
--- a/src/test/regress/sql/reloptions.sql
+++ b/src/test/regress/sql/reloptions.sql
@@ -47,12 +47,12 @@ SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass;
 ALTER TABLE reloptions_test RESET (autovacuum_enabled,
 	autovacuum_analyze_scale_factor);
 SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass AND
-reloptions IS NULL;
+	reloptions IS NULL;
 
 -- RESET fails if a value is specified
 ALTER TABLE reloptions_test RESET (fillfactor=12);
 
--- The OIDS option is not stored
+-- The OIDS option is not stored as reloption
 DROP TABLE reloptions_test;
 CREATE TABLE reloptions_test(i INT) WITH (fillfactor=20, oids=true);
 SELECT reloptions, relhasoids FROM pg_class WHERE oid = 'reloptions_test'::regclass;

--nextPart1828944.xiG0zkXFMd
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--nextPart1828944.xiG0zkXFMd--