Received: from golem.jpl.nasa.gov (root@hectic-2.jpl.nasa.gov [128.149.68.204]) by hub.org (8.8.8/8.7.5) with ESMTP id CAA29341 for ; Tue, 25 Aug 1998 02:21:31 -0400 (EDT) Received: from alumni.caltech.edu (localhost [127.0.0.1]) by golem.jpl.nasa.gov (8.8.5/8.8.5) with ESMTP id GAA25633; Tue, 25 Aug 1998 06:28:35 GMT Sender: tgl@mythos.jpl.nasa.gov Message-ID: <35E25993.CA72C45C@alumni.caltech.edu> Date: Tue, 25 Aug 1998 06:28:35 +0000 From: "Thomas G. Lockhart" Organization: Caltech/JPL X-Mailer: Mozilla 4.05 [en] (X11; I; Linux 2.0.30 i686) MIME-Version: 1.0 To: Bruce Momjian , Tatsuo Ishii CC: hackers@postgreSQL.org Subject: Re: [HACKERS] Open 6.4 items References: <199808250258.WAA02834@candle.pha.pa.us> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit > > > SERIAL type auto-creates sequence > This would be nice to have for 6.4. Someone mentioned you can create > the sequence before the table, so maybe we can jam it in. If it is not > 100% correct, we have a month to make it correct, right? postgres=> create table s (x text, i serial); NOTICE: CREATE TABLE will create implicit sequence s_i_seq for SERIAL column s.i CREATE postgres=> insert into s values ('one'); INSERT 894455 1 postgres=> insert into s values ('two'); INSERT 894456 1 postgres=> insert into s values ('three'); INSERT 894457 1 postgres=> select * from s; x |i -----+- one |1 two |2 three|3 (3 rows) > > > remove PARSEDEBUG defines if not longer needed > Remember, I suggested a way you could keep them with more eligant > defines. Any comments? Well, I think that at least most of them should come out of the code altogether. The more elegant solution probably leads to code clutter also, just a bit more readable since it indents with the rest of the code. > > > double-quotes from pg_dump of field names > > I have some patches for this, but have not had time to test yet. > Cool. Let the beta testers test it! Hmm. So that would make them alpha testers, right? :) Might be OK for this one, if someone is willing to try it. I'd hate to make a change and then forget about it though. Tatsuo? - Tom