Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id E48B41DCB2B2 for ; Mon, 27 Feb 2012 20:29:40 -0400 (AST) Received: from mail.anarazel.de ([217.115.131.40]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1S2Awl-0007vF-JJ for pgsql-hackers@postgresql.org; Tue, 28 Feb 2012 00:29:40 +0000 Received: from android-46ceee622f333344.lan (brln-4dbaa8c0.pool.mediaWays.net [77.186.168.192]) (Authenticated sender: andres@anarazel.de) by mail.anarazel.de (Postfix) with ESMTPSA id B926E448005; Tue, 28 Feb 2012 01:29:25 +0100 (CET) References: <201202272037.25322.andres@anarazel.de> <201202280032.27171.andres@anarazel.de> <22328.1330388498@sss.pgh.pa.us> User-Agent: K-9 Mail for Android In-Reply-To: <22328.1330388498@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Subject: Re: Command Triggers, patch v11 From: "anarazel@anarazel.de" Date: Tue, 28 Feb 2012 01:29:20 +0100 To: Tom Lane CC: pgsql-hackers@postgresql.org, Thom Brown , Dimitri Fontaine Message-ID: <35d4fa81-9f08-49ec-a09b-5ce1b3ab1035@email.android.com> Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -2.6 (--) X-Archive-Number: 201202/1363 X-Sequence-Number: 203727 Tom Lane schrieb: >Andres Freund writes: >> I refreshed the patch so it works again on current HEAD. Basically >some=20 >> trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The >latter doesn't=20 >> seem necessary to me after the changes, so I simply ditched it. Am I >missing=20 >> something? > >No, that was only needed because execMain.c was overriding somebody >else's tuple receiver. If you're putting the right receiver into the >QueryDesc to start with, it shouldn't be necessary. > >I'm confused by this though: > >> This basically includes a revert of >d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b > >I don't find that commit ID anywhere. That should have been the aforementioned commit. Must have screwed up the= copy&paste buffer. Sorry for that. Andres Please excuse the brevity and formatting - I am writing this on my mobile= phone.