Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tQzF0-006Wkh-Sq for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Dec 2024 01:34:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tQzF0-006BQs-3O for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Dec 2024 01:34:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tQzEz-006BQT-P2 for pgsql-hackers@lists.postgresql.org; Fri, 27 Dec 2024 01:34:13 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tQzEs-001nVM-I9 for pgsql-hackers@postgresql.org; Fri, 27 Dec 2024 01:34:12 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2167141dfa1so79233445ad.1 for ; Thu, 26 Dec 2024 17:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735263245; x=1735868045; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jvPA0MlvuqmCimFEG31EySLJuNGzzQ6g+h+71Z19sWM=; b=jztZX1RXKRAksnQYkjuXtyczsZt6vpbngTxJDcFpO+ESoF75oOgZ2nhhWTJDU62bkn zzsjBCguBV4wWKIR7bpgSBVHj6cH3p4VuoeND0iF8o5pTidVuWHNUPdTcHtSFdQ/3H+C DjfiMqdJdpYmWpYpPOOsw0vXMSlE9o98ztOZpWxGp38Npm7qWmKs2fhlyeFkS4Q5Wk0T XEZ1FQ28Hx3aviDbrH61nZUrS4J1kTGPYaFhihuSR80g611J/gOaewO9bvo+gRB3r0kM kwrJZKRrkEiiFLbChpLa1K5XdbHMrOXgAox/f4FpV1dGID6lg2kOKmEC1wspnHOOsmzg FDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735263245; x=1735868045; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvPA0MlvuqmCimFEG31EySLJuNGzzQ6g+h+71Z19sWM=; b=ToqNcnR6oiE8v/CaH0kq4jO/vHlGTHzuOn/IOe1EW3hpLR0uds0aVTFUd/XA/c4g6O ae0j8o8oK3jPrYbZPrAdTdoR4ZyWd9m+rhcClFoCPtbXzzzp07fanKnXKnP4/CX/EcW/ 5KJ/yin95rHuGk7v8Fg3odQtUHDamTPh2GnprfsUw9mGZ1N7solF6yz7wsH16dcq1oZ/ BxtGUyIyHhaGqHlLr/A2OhH2pQQFQ9CtcbAo4DeWbuvvRxp0VHYNH/3GfZZt5wuZkQVq hYT/jx9XWhbIUx7QCC9xbHPT1sf2d8sTHXTUxW8J0dNA20NZius7i8uOswh/pEuMOYGH rhSg== X-Forwarded-Encrypted: i=1; AJvYcCUzz/UM3hss76hmHdLqn2fv6gX7Szs2SsER1+grxJSODckY33HPTrQ1VPcXM+TrqiVEtCzrocWT4Qi1yS+w@postgresql.org X-Gm-Message-State: AOJu0YyAdIHyzjR/j30q4C9BwoOH8dtQZ8SuaFcTVRzKarD55vFnJ7s9 ckFPiwfkdjx3aLbW5M99Ijc7raIHrRvCcitJApx1EM2yPpuYQ/Zy X-Gm-Gg: ASbGncvsn6MsSWIF5my1u4GzAI1l1iI7YjkcsUEOFFZYzAB2zTIOTIbdybA75Dgkqsl 3lN8wDtdz/TBBz4uHJKZk8Z8FVd7AvdnpqyaZjZfv7Ixav3Cf4eyzBw7sDJ307XBCXsHgPkS9TG fMXkz4FfPrrmjYma2lHwNGnW09NtbwPyMIHH+fdY/hm+EXAUz6IN1r47LvYV/jE1TPbBrmk/fPS Ha5s+fnwYhSmKB6Vwcz/K/GLkf1X4iHB5vE7t41eXjBvn/Hnav+izCQ1j4BNJT7Xw1BMvReEPj/ KLWPox8XAUSGMr5a+Tym7hckwKJnT1QV X-Google-Smtp-Source: AGHT+IHXuFfzKSbFAuV6E6YFIS50VrNE82At/ZjeRuiB4WzckrrsamENb3mQkXiJah9ADtqGEZa28w== X-Received: by 2002:a17:903:41c3:b0:215:8fd3:d1b6 with SMTP id d9443c01a7336-219e6d6a221mr384209655ad.23.1735263244636; Thu, 26 Dec 2024 17:34:04 -0800 (PST) Received: from [10.10.20.106] (node-o24.pool-125-26.dynamic.totinternet.net. [125.26.121.204]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc970a4esm125504715ad.104.2024.12.26.17.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Dec 2024 17:34:04 -0800 (PST) Message-ID: <35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com> Date: Fri, 27 Dec 2024 08:34:00 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add Postgres module info To: Yurii Rashkovskii Cc: Tom Lane , PostgreSQL-development References: <506788.1733941263@sss.pgh.pa.us> <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com> <556341.1733967371@sss.pgh.pa.us> <0844622e-9967-409a-8038-470a36f1039c@gmail.com> <8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com> <982748.1734059835@sss.pgh.pa.us> <0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com> Content-Language: en-AU From: Andrei Lepikhov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12/24/24 10:42, Yurii Rashkovskii wrote: > On Mon, Dec 16, 2024 at 12:02 PM Andrei Lepikhov I've reviewed the patch, and it is great that you support more flexible > versioning now. I am just wondering a bit about the case where `minfo- > >name` can be `NULL` but `minfo->version` isn't, or where both are > `NULL` – should we skip any of these? Depends. I wrote code that way so as not to restrict a maintainer by initialising all the fields; remember, it may grow in the future. But I am open to changing that logic. Do you have any specific rule on which fields may be empty and that must be initialised? Do you think all fields maintainer must fill with non-zero-length constants? Also, I've added this patch to commitfest: https://commitfest.postgresql.org/51/5465/ -- regards, Andrei Lepikhov