From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bernd Helmle <mailings@oopsware.de>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Andres Freund <andres@anarazel.de>, Japin Li <japinli@hotmail.com>,
        PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: Modern SHA2- based password hashes for pgcrypto
In-reply-to: <3532284.1744048235@sss.pgh.pa.us>
References: <202504051722.3jv3ashzaibd@alvherre.pgsql>
 <2977905.1743968616@sss.pgh.pa.us>
 <6fab35422df6b6b9727fdcc243c5fa1c667dd3b5.camel@oopsware.de>
 <3532284.1744048235@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 07 Apr 2025 13:50:35 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3601726.1744049815.1@sss.pgh.pa.us>
Date: Mon, 07 Apr 2025 14:16:55 -0400
Message-ID: <3601727.1744049815@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3601727.1744049815%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Bernd Helmle <mailings@oopsware.de> writes:
>> Here is a patch that tries to address all these issues (including
>> Andres' report). I've adjusted the error message and use ereport(), so
>> it might be more useful if we deal with not just single byte letters.

> I'd like to get mamba back to green, so I'll take care of this

And done.  FYI, we actually have a standard practice for error
messages that want to complain about a single character without
assuming it's a single-byte character:

                ereport(ERROR,
                        errcode(ERRCODE_INVALID_PARAMETER_VALUE),
                        errmsg("invalid character in salt string: \"%.*s\"",
                               pg_mblen(ep), ep));

			regards, tom lane