From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Melanie Plageman <melanieplageman@gmail.com>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Small omission in type_sanity.sql
In-reply-to: <20230128012509.5iwjktq4vu4kblef@awork3.anarazel.de>
References: <CAAKRu_ZZnN7XBDsWwEDyE1X=y3xs7GX-L=ftDk9gUg_4sX_awg@mail.gmail.com> <20230128012509.5iwjktq4vu4kblef@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 27 Jan 2023 17:25:09 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3604660.1674869944.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 27 Jan 2023 20:39:04 -0500
Message-ID: <3604661.1674869944@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3604661.1674869944%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Tom, is there a reason we run the various sanity tests early-ish in the
> schedule? It does seem to reduce their effectiveness a bit...

Originally, those tests were mainly needed to sanity-check the
hand-maintained initial catalog data, so it made sense to run them
early.  Since we taught genbki.pl to do a bunch more work, that's
perhaps a bit less pressing.

There's at least one test that intentionally sets up a bogus btree
opclass, which we'd have to drop again if we wanted to run the
sanity checks later.  Not sure what other issues might surface.
You could find out easily enough, of course ...

> Problems:
> - "Cross-check against pg_type entry" is far too strict about legal comb=
inations
>   of typstorage

Perhaps, but it's enforcing policy about what we want in the
initial catalog data, not what is possible to support.  So
there's a bit of divergence of goals here too.  Maybe we need
to split up the tests into initial-data-only tests (run early)
and tests that should hold for user-created objects too
(run late)?

			regards, tom lane