From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Andres Freund <andres@anarazel.de>,
        Andrew Dunstan <andrew@dunslane.net>,
        Robert Haas <robertmhaas@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Cleaning up historical portability baggage
In-reply-to: 
 <CA+hUKGLW6dWAJYQ4q1wXED78L_=tZp0LKi-BNjEaEnqfyWB4vw@mail.gmail.com>
References: 
 <CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com>
 <CA+Tgmoazusui5EoU_7Z=AgwC5pTAqDndTa7d-owjvQwG3zoRhg@mail.gmail.com>
 <CA+hUKGLLJUMDgCzOK5K4NE6PpU87Ka7t7RQsZoZAZ_EKfL5L+A@mail.gmail.com>
 <CA+Tgmoaw6VBC9Xzr4vOaC0kc-94jb9nzH8MY38Gqn7=wy=i_3w@mail.gmail.com>
 <20220712173352.trdeq66asbv6vf2q@awork3.anarazel.de>
 <1662559.1657648462@sss.pgh.pa.us>
 <CA+hUKG+MOzmDkr27ceG8+uwgFxbJUUv699V3VP3DCioQigrf7A@mail.gmail.com>
 <1249825.1658622186@sss.pgh.pa.us>
 <CA+hUKGLryBW4fNYoXzMG9y1e0H-QOTdSiTG46xCr1DNuuPwbeg@mail.gmail.com>
 <CA+hUKGJMcwbzRyfTocfxbPBUhERqKE42d-L22jQ+vpB7an-NjQ@mail.gmail.com>
 <20220804034343.unm4rdynedbigamv@awork3.anarazel.de>
 <3322724.1659586159@sss.pgh.pa.us>
 <CA+hUKGJ5ej33AJL19sQph7Z8SFZ6+aUSKxFTS6pvk2Y8J9Tcwg@mail.gmail.com>
 <295419.1659918447@sss.pgh.pa.us>
 <CA+hUKGK=N8W2uFPdJr07Rs4dgRtbzKaYvCaPQasX3S8=aTO5PQ@mail.gmail.com>
 <747620.1660002360@sss.pgh.pa.us>
 <CA+hUKG+L_3brvh=8e0BW_VfX9h7MtwgN=nFHP5o7X2oZucY9dg@mail.gmail.com>
 <81bb50c!
 a-d0ea-8cb2-7453-a5058a7b49a8@enterprisedb.com>
 <CA+hUKGJdfTFtZXQ8P8CZtyx1k=mHcOD9savHVR2cjSSVp5Uirw@mail.gmail.com>
 <CA+hUKGLW6dWAJYQ4q1wXED78L_=tZp0LKi-BNjEaEnqfyWB4vw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Sun, 14 Aug 2022 00:23:02 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <360947.1660414060.1@sss.pgh.pa.us>
Date: Sat, 13 Aug 2022 14:07:40 -0400
Message-ID: <360948.1660414060@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/360948.1660414060%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> I pushed these, except I chopped out the HAVE_UNIX_SOCKETS part as
> requested.  Here it is in a separate patch, with a commit message that
> explains the rationale (essentially, what you said, it's basically a
> runtime matter for a hypothetical AF_UNIX-less system to complain
> about).  Tom, does this argument persuade you?

I looked more closely and saw that basically what HAVE_UNIX_SOCKETS
is guarding is code that assumes the existence of AF_UNIX and
struct sockaddr_un.  As Peter said, we already rely on AF_UNIX
in some other places; and I see that sys/un.h is required to exist
and to define struct sockaddr_un as far back as SUSv2.  So it
does seem like the worst consequence is that we'd be compiling
some code that would be unreachable on platforms lacking support.
Objection withdrawn.

As for the other two, they look like nice cleanup if we can actually
get away with it.  I agree that the business about nonstandard libbind
is not of interest anymore, but I have no idea about the state of
play on Windows.  I guess we can push 'em and see what the buildfarm
thinks.

> I tried to figure out how to get rid of
> PGAC_STRUCT_SOCKADDR_STORAGE_MEMBERS, but there we're into genuine
> non-standard cross-platform differences.

Right.  I don't think it's worth sweating over.

			regards, tom lane