From: Tom Lane <tgl@sss.pgh.pa.us>
To: vignesh C <vignesh21@gmail.com>
cc: Noah Misch <noah@leadboat.com>, Amit Kapila <amit.kapila16@gmail.com>,
        pgsql-hackers@postgresql.org
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
In-reply-to: 
 <CALDaNm2myhhkoctERWc2x9xA2N3eJojk9h-mAPi-oXatq+ivMA@mail.gmail.com>
References: <20260710045217.f0.noahmisch@microsoft.com>
 <CAA4eK1K8LD243UzHgVNCm4skJZ4UCjR3vowDhKp=cWnK5oBT-Q@mail.gmail.com>
 <20260715025809.cd.noahmisch@microsoft.com>
 <CAA4eK1+k+iKhNtt6bq2SJQm+K_ZYUrS5GCqnf6a6qK6_DrX5Gg@mail.gmail.com>
 <20260715115601.fd.noahmisch@microsoft.com>
 <3614163.1784163070@sss.pgh.pa.us>
 <CALDaNm2myhhkoctERWc2x9xA2N3eJojk9h-mAPi-oXatq+ivMA@mail.gmail.com>
Comments: In-reply-to vignesh C <vignesh21@gmail.com>
	message dated "Thu, 16 Jul 2026 08:11:51 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3621807.1784170708.1@sss.pgh.pa.us>
Date: Wed, 15 Jul 2026 22:58:28 -0400
Message-ID: <3621808.1784170708@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3621808.1784170708%40sss.pgh.pa.us>
Precedence: bulk

vignesh C <vignesh21@gmail.com> writes:
> On Thu, 16 Jul 2026 at 06:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That is, after checking for the "insufficient privileges" case,
>> we aren't waiting long enough for the new seqsync worker to quiesce.
>> This wasn't a problem before f38afa4ab, because it wasn't an error
>> condition for that worker to still be running.

> I think we can simply remove the REFRESH SEQUENCES command and add a
> comment explaining that the sequence synchronization worker is
> restarted automatically while there are sequences that are not yet in
> the READY state.

Well, that would fix this test, but I wonder if this result isn't
telling us that f38afa4ab has created a failure condition that will
bite real users.  Why would the user issuing REFRESH SEQUENCES be
aware of whether there's a sync worker running right then?  Why
should it be his problem to avoid that?

			regards, tom lane