MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Thu, 29 Sep 2022 11:29:40 +0900
From: bt22nakamorit <bt22nakamorit@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
In-Reply-To: <6fd74d4bf62664b0320cde3f7a48f522@oss.nttdata.com>
References: <eaf326ad693e74eba068f33a7f518039@oss.nttdata.com>
 <20220916.173035.322733707258561235.horikyota.ntt@gmail.com>
 <4c61d434cb72b2237b3279797b2a387f@oss.nttdata.com>
 <8a022f2c8de93ea79116f0b7eb42248a@oss.nttdata.com>
 <6fd74d4bf62664b0320cde3f7a48f522@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <36360350378935c823a9dbbff5b2e54e@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/36360350378935c823a9dbbff5b2e54e%40oss.nttdata.com>
Precedence: bulk

2022-09-28 21:49 に torikoshia さんは書きました:
>>    if (result == 127 || result == -1)
>>    {
>>        pg_log_error("\\!: failed");
>>        return false;
>>    }
>>    else if (result != 0) {
>>        pg_log_error("command failed");
>>        return false;
> 
> Since it would be hard to understand the cause of failures from these
> two messages,　it might be better to clarify them in the messages.
> 
> The former comes from failures of child process creation or execution
> on it and the latter occurs when child process creation and execution
> succeeded but the return code is not 0, doesn't it?
> 
> 
> I also felt it'd be natural that the latter message also begins with
> "\\!" since both message concerns with \!.
> 
> How do you think?

Thank you for the feedback!
I agree that the messages should be more clear.
\\!: command was not executed
\\!: command failed
Would these two messages be enough to describe the two cases?

Tatsu