Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSrrU-0000eA-ET for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Oct 2020 01:15:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kSrrT-0000UL-9E for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Oct 2020 01:15:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSrrT-0000Tg-2k for pgsql-hackers@lists.postgresql.org; Thu, 15 Oct 2020 01:15:19 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSrrQ-0003Pm-Sq for pgsql-hackers@postgresql.org; Thu, 15 Oct 2020 01:15:18 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 09F1FD0W3643531; Wed, 14 Oct 2020 21:15:13 -0400 From: Tom Lane To: David Rowley cc: Justin Pryzby , PostgreSQL-development , Andres Freund Subject: Re: jit and explain nontext In-reply-to: References: <20201014193859.GS9241@telsasoft.com> Comments: In-reply-to David Rowley message dated "Thu, 15 Oct 2020 14:02:15 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3643529.1602724513.1@sss.pgh.pa.us> Date: Wed, 14 Oct 2020 21:15:13 -0400 Message-ID: <3643530.1602724513@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk David Rowley writes: > Just for some reference. Some wisdom was shared in [1], which made a > lot of sense to me. > If we apply that, then we just need to decide if displaying any jit > related fields without any jitted expressions is relevant. Hmm, I dunno if my opinion counts as "wisdom", but what I was arguing for there was that we should print stuff if it's potentially invoked by a run-time decision, but not if it was excluded at plan time. I'm not totally clear on whether jitting decisions are fixed by the plan tree (including its cost values) or if the executor can make different decisions in different executions of the identical plan tree. If the latter, then I agree with Justin that this is a bug. regards, tom lane