From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: jian he <jian.universality@gmail.com>,
        Pg Hackers <pgsql-hackers@lists.postgresql.org>,
        Tender Wang <tndrwang@gmail.com>
Subject: Re: not null constraints, again
In-reply-to: <202411081308.nxj6dy2xui6a@alvherre.pgsql>
References: <202411081308.nxj6dy2xui6a@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 08 Nov 2024 14:08:10 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3649827.1731083171.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 08 Nov 2024 11:26:11 -0500
Message-ID: <3649828.1731083171@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3649828.1731083171%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> But we'll see what else the buildfarm has to say now that I pushed it ..=
.

A lot of the buildfarm is saying

 adder         | 2024-11-08 13:04:39 | ../pgsql/src/backend/catalog/pg_con=
straint.c:708:37: warning: comparison is always true due to limited range =
of data type [-Wtype-limits]

which evidently is about this:

	Assert(colnum > 0 && colnum <=3D MaxAttrNumber);

The memcpy right before that doesn't seem like project style either.
Most other places that are doing similar things just cast the
ARR_DATA_PTR to the right pointer type and dereference it.

			regards, tom lane