From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, iwata.aya@fujitsu.com,
        tsunakawa.takay@fujitsu.com, k.jamison@fujitsu.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-reply-to: <20210402135218.GA13909@alvherre.pgsql>
References: <20210402135218.GA13909@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 02 Apr 2021 10:52:18 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3650139.1617372290.1@sss.pgh.pa.us>
Date: Fri, 02 Apr 2021 10:04:50 -0400
Message-ID: <3650140.1617372290@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3650140.1617372290%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> As in the attached patch.

+1, but the comment could be more specific.  Maybe like "In regress mode,
suppress the length of ErrorResponse and NoticeResponse messages --- the F
(file name) field, in particular, can vary in length depending on compiler
used."

Actually though ... I recall now that elog.c tries to standardize the F
output by stripping the path part:

		/* keep only base name, useful especially for vpath builds */
		slash = strrchr(filename, '/');
		if (slash)
			filename = slash + 1;

I bet what is happening on drongo is that the compiler has generated a
__FILE__ value that contains backslashes not slashes, and this code
doesn't know how to shorten those.  So maybe instead of lobotomizing
this test, we should fix that.

		slash = strrchr(filename, '/');
+		if (!slash)
+			slash = strrchr(filename, '\\');
		if (slash)
			filename = slash + 1;

			regards, tom lane