From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Readd use of TAP subtests
In-reply-to: <7e67b831-9eae-cd19-c96c-c1e59d916498@dunslane.net>
References: <9878e1e2-2ce3-6df0-3498-07d967534f5e@enterprisedb.com>
 <87zgpbnr59.fsf@wibble.ilmari.org>
 <6131CFD1-EC47-41ED-999E-AB28B40DDEAA@yesql.se>
 <87wnkfnq9m.fsf@wibble.ilmari.org>
 <7e67b831-9eae-cd19-c96c-c1e59d916498@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 08 Dec 2021 09:33:06 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3654395.1638977132.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 08 Dec 2021 10:25:32 -0500
Message-ID: <3654396.1638977132@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3654396.1638977132%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 12/8/21 09:08, Dagfinn Ilmari Mannsåker wrote:
>> Either way, I think we should be switching tests to done_testing()
>> whenever it would otherwise have to adjust the test count, to avoid
>> having to do that again and again and again going forward.

> I'm not so sure. I don't think its necessarily a bad idea to have to
> declare how many tests you're going to run.

I think the main point is to make sure that the test script reached an
intended exit point, rather than dying early someplace.  It's not apparent
to me why reaching a done_testing() call is a less reliable indicator of
that than executing some specific number of tests --- and I agree with
ilmari that maintaining the test count is a serious PITA.

			regards, tom lane