public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: David Rowley <[email protected]>
Cc: [email protected]
Subject: Re: Speeding up ruleutils' name de-duplication code, redux
Date: Tue, 10 Sep 2024 16:36:00 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvqMRD10-HEK5eXZDgo1NqjizdSg8Taqbakno1kAxaNuyA@mail.gmail.com>
References: <[email protected]>
	<CAApHDvriAQ4W=2B-t7R+N77Bmq+HZLAf3ReQiyGXeZMke7yibQ@mail.gmail.com>
	<[email protected]>
	<CAApHDvqMRD10-HEK5eXZDgo1NqjizdSg8Taqbakno1kAxaNuyA@mail.gmail.com>

David Rowley <[email protected]> writes:
> On Wed, 11 Sept 2024 at 03:06, Tom Lane <[email protected]> wrote:
>> We could accomplish what you suggest by re-ordering the calls so that
>> we build the hash table before enlarging the array.  0001 attached
>> is the same as before (modulo line number changes from being rebased
>> up to HEAD) and then 0002 implements this idea on top.  On the whole
>> though I find 0002 fairly ugly and would prefer to stick to 0001.
>> I really doubt that scanning any newly-created column positions is
>> going to take long enough to justify intertwining things like this.

> I'm fine with that.  I did test the performance with and without
> v2-0002 and the performance is just a little too noisy to tell. Both
> runs I did with v2-0002, it was slower, so I agree it's not worth
> making the code uglier for.
> I've no more comments. Looks good.

Thanks for the review!  I'll go push just 0001.

			regards, tom lane

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Speeding up ruleutils' name de-duplication code, redux
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox