From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema <postgres@jeltef.nl>
cc: Andrew Dunstan <andrew@dunslane.net>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
References: <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com> <1708030.1675446770@sss.pgh.pa.us> <20230204041848.GC1896331@rfd.leadboat.com> <20230204113453.vmtnayjvhyg5qqqy@alap3.anarazel.de> <1923921.1675526879@sss.pgh.pa.us> <20230204171101.GF1653@telsasoft.com> <2009472.1675532231@sss.pgh.pa.us> <CA+TgmoY59Ksso81RNLArNxj0a7xaqV_F_u7gSMHbgdc2kG5Vpw@mail.gmail.com> <ef4c7196-24b0-9fe9-1b5e-3ec8a5c34c7b@dunslane.net> <CA+TgmoYTg4avVbkzhhQi3Z-HoxsAvtD=tZiSdWZU9avF_2ouZA@mail.gmail.com> <3d67bc80-4de2-5ba8-e272-e4ad2e59ba04@dunslane.net> <4ac8f263-f1bb-faa5-a307-1fffe00f0e3e@dunslane.net> <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com> <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net> <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net> <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com> <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com> !
 <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net> <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com>
Comments: In-reply-to Jelte Fennema <postgres@jeltef.nl>
	message dated "Fri, 21 Apr 2023 09:58:17 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3665233.1682174388.1@sss.pgh.pa.us>
Date: Sat, 22 Apr 2023 10:39:48 -0400
Message-ID: <3665234.1682174388@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3665234.1682174388%40sss.pgh.pa.us>
Precedence: bulk

Jelte Fennema <postgres@jeltef.nl> writes:
> I think there's two things needed to actually start doing this:
> 1. We need to reindent the tree to create an indented baseline

As far as (1) goes, I've been holding off on that because there
are some large patches that still seem in danger of getting
reverted, notably 2489d76c4 and follow-ups.  A pgindent run
would change any such reversions from being mechanical into
possibly a fair bit of work.  We still have a couple of weeks
before it's necessary to make such decisions, so I don't want
to do the pgindent run before that.

Another obstacle in the way of (1) is that there was some discussion
of changing perltidy version and/or options.  But I don't believe
we have a final proposal on that, much less committed code.

			regards, tom lane