Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u1sb7-009gVz-Ts for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Apr 2025 19:57:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u1sb5-003WIe-Sb for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Apr 2025 19:57:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u1sb5-003WIT-JF for pgsql-hackers@lists.postgresql.org; Mon, 07 Apr 2025 19:57:31 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u1sb3-003z3e-1o for pgsql-hackers@lists.postgresql.org; Mon, 07 Apr 2025 19:57:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 537JvPw83668854; Mon, 7 Apr 2025 15:57:26 -0400 From: Tom Lane To: Dmitrii Bondar cc: Paul Jungwirth , PostgreSQL Hackers , Lilian Subject: Re: [fixed] Trigger test In-reply-to: <2720306.1743882858@sss.pgh.pa.us> References: <79755a2b18ed4fe5e29da6a87a1e00d1@postgrespro.ru> <7879fede654a17b9fcc8548de2cb3f69@postgrespro.ru> <174293570374.60294.13024599409215069922.pgcf@coridan.postgresql.org> <17a8a24f7295201873d105c5118024f5@postgrespro.ru> <766da800-4884-41a9-8e8e-71d131dc599c@illuminatedcomputing.com> <81a79dfc-b6b1-4155-90b6-c06201d84afb@postgrespro.ru> <1441543.1743703890@sss.pgh.pa.us> <2720306.1743882858@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Sat, 05 Apr 2025 15:54:18 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3668852.1744055845.1@sss.pgh.pa.us> Date: Mon, 07 Apr 2025 15:57:25 -0400 Message-ID: <3668853.1744055845@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > Dmitrii Bondar writes: >> I considered removing it entirely, but that seemed too drastic a >> solution (and, at the very least, I don't have enough expertise to make >> that decision). > I'm not that thrilled with giving up on refint.c either. But in its > current state, it's a pretty lousy example. Are we willing to put > enough effort into making it a more useful code example? I concluded that we might as well commit what we've got, since the window for v18 is closing fast and there's not time to consider anything more invasive. Hence, pushed. I hope you will consider spending some effort on fixing the other problems identified in this thread. regards, tom lane