Message-ID: <36796438-a718-cf9b-2071-b2c1b947c1b5@gmail.com>
Date: Sat, 29 Jun 2024 10:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: LogwrtResult contended spinlock
Content-Language: en-US
To: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
 Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@lists.postgresql.org,
 Jaime Casanova <jcasanov@systemguards.com.ec>
References: <202404071219.p5qphx7vzxte@alvherre.pgsql>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <202404071219.p5qphx7vzxte@alvherre.pgsql>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/36796438-a718-cf9b-2071-b2c1b947c1b5%40gmail.com>
Precedence: bulk

Hello Alvaro and Bharath,

07.04.2024 15:19, Alvaro Herrera wrote:
> I pushed the "copy" pointer now, except that I renamed it to "insert",
> which is what we call the operation being tracked.  I also added some
> comments.

I've discovered that Windows x86 build fails tests after commit f3ff7bf83.
Using "x86 Native Tools Command Prompt for VS 2022", I do:
meson setup build -Dcassert=true
cd build
ninja
meson test --suite setup

and get:
1/3 postgresql:setup / tmp_install               OK 1.56s
2/3 postgresql:setup / install_test_files        OK 0.09s
3/3 postgresql:setup / initdb_cache              FAIL 1.88s   exit status 1

testlog.txt contains:
running bootstrap script ...
----------------------------------- stderr -----------------------------------
TRAP: failed Assert("TYPEALIGN(8, (uintptr_t)(&currval)) == (uintptr_t)(&currval)"), File: 
"...\src\include\port/atomics.h", Line: 597, PID: 7556
child process was terminated by exception 0xC0000409

On f3ff7bf83~1, `meson test --suite setup` passes for me.

(I could not find if support for 32-bit Windows ended, so decided to
report this.)

Best regards,
Alexander