Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oJk8r-0005Hk-Go
	for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Aug 2022 23:20:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oJk8p-0000ak-Ef
	for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Aug 2022 23:20:35 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oJk8p-0000ZZ-5K
	for pgsql-hackers@lists.postgresql.org; Thu, 04 Aug 2022 23:20:35 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oJk8k-0000e8-1l
	for pgsql-hackers@lists.postgresql.org; Thu, 04 Aug 2022 23:20:31 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 274NKG8P3684409;
	Thu, 4 Aug 2022 19:20:16 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Ashutosh Sharma <ashu.coek88@gmail.com>,
        Maciek Sakrejda <m.sakrejda@gmail.com>,
        Bruce Momjian <bruce@momjian.us>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Andrew Dunstan <andrew@dunslane.net>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
In-reply-to: <20220804231204.kcr6sfpshzvt5qi3@awork3.anarazel.de>
References: <2767668.1659476794@sss.pgh.pa.us>
 <20220802220416.GC13682@telsasoft.com>
 <20220802222334.umf5wsa2r63koppn@awork3.anarazel.de>
 <CAFiTN-sG9-ocJFN+KBAQ2mTuF-9Ja+i1Qo81yqr0WDOsqqYpLg@mail.gmail.com>
 <CAFiTN-sL8M+Z6nongs=rSqfP26Vr0O_EYLfcwbO-Emz1GYxtxA@mail.gmail.com>
 <CAFiTN-v4u2WJT6y1n4wtM4Z3tffJonT7zuRKegYao9p-Oyb07Q@mail.gmail.com>
 <CAFiTN-thCGvRF0_WftbDc0KFagB3vgHHGrpNdRMJ6vtkObEMoA@mail.gmail.com>
 <CA+Tgmoa9Heqc3mr=viBQ0Y0tqQz5G8oUAc23ZmbNW5__cud28A! ! @mail.gmail.com>
 <3663919.1659650570@sss.pgh.pa.us> <3679800.1659654066@sss.pgh.pa.us>
 <20220804231204.kcr6sfpshzvt5qi3@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 04 Aug 2022 16:12:04 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3684407.1659655216.1@sss.pgh.pa.us>
Date: Thu, 04 Aug 2022 19:20:16 -0400
Message-ID: <3684408.1659655216@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3684408.1659655216%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-08-04 19:01:06 -0400, Tom Lane wrote:
>> (This seems worth fixing before beta3, as it looks like a rather
>> nasty data corruption hazard.)

> Ugh, yes. And even with this fixed I think this should grow at least an
> assertion that the block numbers match, probably even an elog.

Yeah, the assumption that P_NEW would automatically match the source block
was making me itchy too.  An explicit test-and-elog seems worth the
cycles.

			regards, tom lane