Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRcYW-0004CY-2j for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Mar 2022 16:19:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nRcYU-00020I-Vt for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Mar 2022 16:19:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRcYU-000209-Mv for pgsql-hackers@lists.postgresql.org; Tue, 08 Mar 2022 16:19:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRcYS-0001Qj-3I for pgsql-hackers@postgresql.org; Tue, 08 Mar 2022 16:19:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 228GJIhk368486; Tue, 8 Mar 2022 11:19:18 -0500 From: Tom Lane To: Dong Wook Lee cc: pgsql-hackers@postgresql.org Subject: Re: Add pg_freespacemap extension sql test In-reply-to: References: Comments: In-reply-to Dong Wook Lee message dated "Tue, 08 Mar 2022 23:43:47 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <368484.1646756358.1@sss.pgh.pa.us> Date: Tue, 08 Mar 2022 11:19:18 -0500 Message-ID: <368485.1646756358@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dong Wook Lee writes: > [ 0001_add_test_pg_fsm.patch ] I think having some coverage here would be great, but I'm concerned that this patch doesn't look very portable. Aren't the numbers liable to change on 32-bit machines, in particular? regards, tom lane