From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Evan Jones <evan.jones@datadoghq.com>, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
In-reply-to: <ZJI+G7B/qblD6/Fc@paquier.xyz>
References: <CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com> <ZIZkMf6rfCVQaKgO@paquier.xyz> <CA+HWA9bTRDf52DHyU+JOoqEALgRGRo5uHUYTFuduoj3cBfer+Q@mail.gmail.com> <ZI5i2NCWirDuE/Iq@paquier.xyz> <ZI7BD6jTsn4vdCxe@paquier.xyz> <2765603.1687106292@sss.pgh.pa.us> <ZI+TK2kch0ZZ/Amk@paquier.xyz> <2823519.1687137059@sss.pgh.pa.us> <ZJFA2hpiuOmGuE6N@paquier.xyz> <CA+HWA9ZRRxdL5FFTM4eTDyhmnzC-0tAo1kmu8Mndtjvs4O=G0Q@mail.gmail.com> <ZJI+G7B/qblD6/Fc@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 21 Jun 2023 09:02:35 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3685078.1687318771.1@sss.pgh.pa.us>
Date: Tue, 20 Jun 2023 23:39:31 -0400
Message-ID: <3685079.1687318771@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3685079.1687318771%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> As a whole, I'd like to think that this is an improvement even for
> stable branches with these weird isspace() handlings, so I'm OK with
> the current status in all the branches.

Sounds like we're all content with that.

> There's an argument about \v,
> IMO, but I won't fight hard for it either even if it would be more
> consistent with the way array values are handled.

I'd be okay with adding \v to the set of whitespace characters in
scan.l and scanner_isspace (and other affected places) for v17.
Don't want to back-patch it though.

			regards, tom lane