Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wK1L4-000V8M-0u for pgsql-hackers@arkaria.postgresql.org; Mon, 04 May 2026 22:00:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wK1L2-0095Y8-2E for pgsql-hackers@arkaria.postgresql.org; Mon, 04 May 2026 22:00:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wK1L2-0095Xz-1K for pgsql-hackers@lists.postgresql.org; Mon, 04 May 2026 22:00:28 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wK1L0-00000000D7T-0ENy for pgsql-hackers@lists.postgresql.org; Mon, 04 May 2026 22:00:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 644M02gY368856; Mon, 4 May 2026 18:00:03 -0400 From: Tom Lane To: Daniel Gustafsson cc: Zsolt Parragi , Michael Banck , Jacob Champion , Jelte Fennema-Nio , Heikki Linnakangas , "li.evan.chao" , Michael Paquier , Andres Freund , Pgsql Hackers Subject: Re: Serverside SNI support in libpq In-reply-to: References: <1C38F269-E552-4F78-9E88-E91CEDB12F35@yesql.se> <23D19F69-A8DE-4F89-99F6-5FC48762CE4D@yesql.se> <561BF011-1626-43A5-BD82-913E67EEBA8B@yesql.se> <7DA91781-AA47-447A-BA6F-99FE7E83954E@yesql.se> <1CEF92A7-B41A-46A2-BEBA-34307BFE594B@yesql.se> <359138.1777922557@sss.pgh.pa.us> Comments: In-reply-to Daniel Gustafsson message dated "Mon, 04 May 2026 22:31:36 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <368854.1777932002.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 04 May 2026 18:00:02 -0400 Message-ID: <368855.1777932002@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Daniel Gustafsson writes: >> On 4 May 2026, at 21:22, Tom Lane wrote: >> As a side matter, "load_host" seems like a remarkably generic name >> that conveys little about what it actually does, > It's following the naming convention of load_hba() which reads pg_hba.co= nf, and > load_ident() which reads pg_ident.conf - thus load_hosts() for the funct= ion > that reads pg_hosts.conf. Perhaps load_pg_hosts_conf() or load_hosts_co= nfig() > would convey more meaning? Hmm, okay. I'd prefer a more specific name, but it wouldn't make much sense unless we also rename those two. That's probably more code churn than is justified. I'll push the thing for moving/using the typedef, but leave the function name alone. regards, tom lane