From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
cc: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
        Peter Geoghegan <pg@bowt.ie>, Thomas Munro <thomas.munro@gmail.com>,
        "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
        Stephen Frost <sfrost@snowman.net>,
        Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>,
        Dilip Kumar <dilipbalaut@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
In-reply-to: <4F10540A-9022-49EE-A6FC-7FE90797793E@enterprisedb.com>
References: 
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
 <20210313184612.GA3195145@rfd.leadboat.com>
 <930621E5-5D10-456D-8CE4-CF629A6C4669@enterprisedb.com>
 <20210313191841.GB3195145@rfd.leadboat.com>
 <3012106.1615827854@sss.pgh.pa.us>
 <C2C142F3-F740-4197-B507-20B28B7395AC@enterprisedb.com>
 <3053552.1615834640@sss.pgh.pa.us>
 <AA5506CE-7D2A-42E4-A51D-358635E3722D@enterprisedb.com>
 <CA+TgmoYAi_3_sCnsH2qwVFW1WUGqn3xOcGWjjvDtn4j4xfso+A@mail.gmail.com>
 <4F10540A-9022-49EE-A6FC-7FE90797793E@enterprisedb.com>
Comments: In-reply-to Mark Dilger <mark.dilger@enterprisedb.com>
	message dated "Wed, 17 Mar 2021 21:00:39 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3692626.1616040747.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 18 Mar 2021 00:12:27 -0400
Message-ID: <3692627.1616040747@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3692627.1616040747%40sss.pgh.pa.us>
Precedence: bulk

Mark Dilger <mark.dilger@enterprisedb.com> writes:
>> On Mar 16, 2021, at 12:52 PM, Robert Haas <robertmhaas@gmail.com> wrote=
:
>> Since we now know that shutting autovacuum off makes the problem go
>> away, I don't see a reason to commit 0001. We should fix pg_amcheck
>> instead, if, as presently seems to be the case, that's where the
>> problem is.

> If you get unlucky, autovacuum will process one of the tables that the t=
est intentionally corrupted, with bad consequences, ultimately causing bui=
ld farm intermittent test failures.

Um, yeah, the test had better shut off autovacuum on any table that
it intentionally corrupts.

			regards, tom lane