Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE
 DOMAIN statement
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <6a131cc6-ab35-49d2-b9bf-e6ddae4cf3b1@gmail.com>
Date: Thu, 20 Nov 2025 16:47:19 +0800
Cc: pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <36A72FEF-F07E-40A8-8022-998D5DA6FD04@gmail.com>
References: 
 <CAPgqM1V4LW2qiDLPsusb7s0kYbSDJjH5Tt+-ZzVmPU7xV0TJNQ@mail.gmail.com>
 <CACJufxE_8DveuvpiSnnRpeRGC9UdGY6X7ZptNt08-x+v-_5QQg@mail.gmail.com>
 <CAPgqM1URzR017U5gEK6S5dYz8VdYMaJf82G9sZFq5xbpHR1J_g@mail.gmail.com>
 <E3B668DD-7D16-418F-819A-052B893C1B02@gmail.com>
 <CAPgqM1XBMQGP=w2a9jajGkrGMzVk0rGBm0+F1pnwsZnn_U6YoQ@mail.gmail.com>
 <CANxoLDeXxHgZXcO1HAimT0KkZm19wjLvNXct+sq7Lg+aBFKG3w@mail.gmail.com>
 <CAPgqM1XwWz3SWnkBwy+RSZ-XEPq7i=Hb52AA2-b5qXdEg9XNQA@mail.gmail.com>
 <6a131cc6-ab35-49d2-b9bf-e6ddae4cf3b1@gmail.com>
To: Florin Irion <irionr@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/36A72FEF-F07E-40A8-8022-998D5DA6FD04%40gmail.com>
Precedence: bulk


> On Nov 12, 2025, at 00:14, Florin Irion <irionr@gmail.com> wrote:
>=20
> Hello, Cirrus-CI was complaining because we don't sort the constraints =
and thus
> they were making the test fail because of the random order.
> Made it sort with `list_sort`and `list_oid_cmp`not sure if that's the =
best
> thing to sort them.
> Check v4 attached.
> Cheers,
> Florin Irion
> Tim Waizenegger
> EDB (EnterpriseDB)
> <v4-0001-Add-pg_get_domain_ddl-function-to-reconstruct-CRE.patch>

I just tested v4, and see two problems:

```
evantest=3D# CREATE DOMAIN public.int AS pg_catalog.int4;
CREATE DOMAIN
evantest=3D# SELECT pg_get_domain_ddl('int');
ERROR:  cache lookup failed for type 0
evantest=3D#
evantest=3D#
evantest=3D# SELECT pg_get_domain_ddl('pg_class');
ERROR:  cache lookup failed for type 0
evantest=3D#
evantest=3D#
evantest=3D# SELECT pg_get_domain_ddl('public.int');
               pg_get_domain_ddl
------------------------------------------------
 CREATE DOMAIN public."int" AS pg_catalog.int4;
(1 row)

evantest=3D# show search_path;
   search_path
-----------------
 "$user", public
(1 row)
```

1. The error message "cache lookup failed for type 0=E2=80=9D looks not =
good. At lease saying something like =E2=80=9Cdomain =E2=80=98int=E2=80=99=
 does not exist=E2=80=9D.

2. I created a domain =E2=80=9Cint=E2=80=9D in =E2=80=9Cpublic=E2=80=9D, =
as you see, =E2=80=9Cpublic=E2=80=9D is in the search_path, but SELECT =
pg_get_domain_ddl('int=E2=80=99); failed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/