Feedback-ID: i131946ab:Fastmail
Message-ID: <36c2ad45-e1d1-e024-f52d-2c11b8cb8e7a@enterprisedb.com>
Date: Wed, 22 Feb 2023 09:56:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: ANY_VALUE aggregate
Content-Language: en-US
To: Vik Fearing <vik@postgresfriends.org>, David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <5cff866c-10a8-d2df-32cb-e9072e6b04a2@postgresfriends.org>
 <bf4652c9-0283-af94-31c5-3ac936f07878@postgresfriends.org>
 <464ece4e-fabb-ddac-60da-897493c4476d@enterprisedb.com>
 <538ac95d-f12e-92b8-0e22-85b6e35fdec9@postgresfriends.org>
 <CAApHDvoCMki1NWLyeijUj_P5uxymWejGf5r2zX7o_JOEku_55Q@mail.gmail.com>
 <15c31fa6-b84a-8705-f5a2-987d165a89db@postgresfriends.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <15c31fa6-b84a-8705-f5a2-987d165a89db@postgresfriends.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/36c2ad45-e1d1-e024-f52d-2c11b8cb8e7a%40enterprisedb.com>
Precedence: bulk

On 09.02.23 10:42, Vik Fearing wrote:
> v4 attached.  I am putting this back to Needs Review in the commitfest 
> app, but these changes were editorial so it is probably RfC like Peter 
> had set it.  I will let you be the judge of that.

I have committed this.

I made a few small last-minute tweaks:

- Changed "non-deterministic" to "arbitrary", as suggested by Maciek 
Sakrejda nearby.  This seemed like a handier and less jargony term.

- Removed trailing whitespace in misc.c.

- Changed the function description in pg_proc.dat.  Apparently, we are 
using 'aggregate transition function' there for all aggregate functions 
(instead of 'any_value transition function' etc.).

- Made the tests a bit more interested by feeding in more rows and a mix 
of null and nonnull values.