Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gtmDX-0002Sd-7J for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Feb 2019 04:32:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gtmDV-0005mI-F2 for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Feb 2019 04:32:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gtmDV-0005m6-11 for pgsql-hackers@lists.postgresql.org; Wed, 13 Feb 2019 04:32:13 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gtmDO-0004Wm-4Q for pgsql-hackers@lists.postgresql.org; Wed, 13 Feb 2019 04:32:11 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x1D4W363025679; Wed, 13 Feb 2019 13:32:03 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 12DE2EA7A9E; Wed, 13 Feb 2019 13:32:03 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 08891EA7A82; Wed, 13 Feb 2019 13:32:03 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 03EA240072A; Wed, 13 Feb 2019 13:32:03 +0900 (JST) Subject: Re: monitoring CREATE INDEX [CONCURRENTLY] References: <20190212031824.GA14185@alvherre.pgsql> From: Amit Langote Message-ID: <36d781d7-e0f3-e2e9-b4b4-70e0b481a1ed@lab.ntt.co.jp> Date: Wed, 13 Feb 2019 13:31:53 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190212031824.GA14185@alvherre.pgsql> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Alvaro Herrera , Rahila Syed Cc: Pg Hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Alvaro, On 2019/02/12 12:18, Alvaro Herrera wrote: > I ended up defining phases for the index_build phase in the AM itself; > the code reports a phase number using the regular API, and then the > pgstat_progress view obtains the name of each phase using a support > method. diff --git a/doc/src/sgml/indexam.sgml b/doc/src/sgml/indexam.sgml index 05102724ead..189179a5667 100644 --- a/doc/src/sgml/indexam.sgml +++ b/doc/src/sgml/indexam.sgml @@ -127,6 +127,7 @@ typedef struct IndexAmRoutine amcostestimate_function amcostestimate; amoptions_function amoptions; amproperty_function amproperty; /* can be NULL */ + amphasename_function amphasename; /* can be NULL */ Doesn't the name amphasename sound a bit too generic, given that it can only describe the phases of ambuild? Maybe ambuildphase? Thanks, Amit