Message-ID: <36ea800b7b537c89d92bcd109b3858c72c16a14c.camel@cybertec.at>
Subject: Re: [PATCH] Add support function for containment operators
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Kim Johan Andersson <kimjand@kimmet.dk>, 
	pgsql-hackers@lists.postgresql.org
Date: Tue, 01 Aug 2023 04:07:24 +0200
In-Reply-To: <4cdc292e-3234-a03d-107d-31cf8b721cd4@kimmet.dk>
References: <94f64d1f-b8c0-b0c5-98bc-0793a34e0851@kimmet.dk>
	 <4e6efd382b3195eb7ea438b7219cc94d9399c0bd.camel@cybertec.at>
	 <147ac793f2c3a9a57764fba84988a4b5e843443b.camel@cybertec.at>
	 <4cdc292e-3234-a03d-107d-31cf8b721cd4@kimmet.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/36ea800b7b537c89d92bcd109b3858c72c16a14c.camel%40cybertec.at>
Precedence: bulk

On Sat, 2023-07-08 at 08:11 +0200, Kim Johan Andersson wrote:
> On 07-07-2023 13:20, Laurenz Albe wrote:
> > I wrote:
> > > You implement both "SupportRequestIndexCondition" and "SupportRequest=
Simplify",
> > > but when I experimented, the former was never called.=C2=A0 That does=
 not
> > > surprise me, since any expression of the shape "expr <@ range constan=
t"
> > > can be simplified.=C2=A0 Is the "SupportRequestIndexCondition" branch=
 dead code?
> > > If not, do you have an example that triggers it?
>=20
> I would think it is dead code, I came to the same conclusion. So we can=
=20
> drop SupportRequestIndexCondition, since the simplification happens to=
=20
> take care of everything.
>=20
>=20
> > I had an idea about this:
> > So far, you only consider constant ranges.=C2=A0 But if we have a STABL=
E range
> > expression, you could use an index scan for "expr <@ range", for exampl=
e
> > Index Cond (expr >=3D lower(range) AND expr < upper(range)).
> >=20
>=20
> I will try to look into this. Originally that was what I was hoping for,=
=20
> but didn't see way of going about it.
>=20
> Thanks for your comments, I will also look at the locale-related=20
> breakage you spotted.

I have marked the patch as "returned with feedback".

I encourage you to submit an improved version in a future commitfest!

Yours,
Laurenz Albe