Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tRzTX-00D7jB-LL
	for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Dec 2024 20:01:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tRzTW-007el5-RU
	for pgsql-hackers@arkaria.postgresql.org; Sun, 29 Dec 2024 20:01:22 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tRzTW-007ekw-HW
	for pgsql-hackers@lists.postgresql.org; Sun, 29 Dec 2024 20:01:22 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tRzTU-00195I-2y
	for pgsql-hackers@lists.postgresql.org;
	Sun, 29 Dec 2024 20:01:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4BTK1GK03701773;
	Sun, 29 Dec 2024 15:01:16 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
In-reply-to: <3633307.1735498615@sss.pgh.pa.us>
References: <3395418.1618352794@sss.pgh.pa.us> <ZywSnWzXskAxSDew@paquier.xyz>
 <ZzMSJkiNZhimjXWx@paquier.xyz> <2345099.ElGaqSPkdT@aivenlaptop>
 <ZzV88-6lOrqd1LNU@paquier.xyz> <1400205.1734199200@sss.pgh.pa.us>
 <1471865.1734212070@sss.pgh.pa.us> <1493397.1734214099@sss.pgh.pa.us>
 <3633307.1735498615@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sun, 29 Dec 2024 13:56:55 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3701771.1735502476.1@sss.pgh.pa.us>
Date: Sun, 29 Dec 2024 15:01:16 -0500
Message-ID: <3701772.1735502476@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3701772.1735502476%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I reviewed and pushed these.  Let's not forget that the pageinspect
> one is still pending, though.  We were waiting on Tomas' fix, which
> is now pushed at 957ba9ff1, so I suppose it needs a rebase.

Actually ... that one's quite trivial, so I went ahead and pushed it.

The submitted patch had the functions as PARALLEL SAFE, but I think
they have to remain PARALLEL RESTRICTED because they use
tuple_data_split(), cf pageinspect--1.10--1.11.sql.

			regards, tom lane