From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: pg17.3 PQescapeIdentifier() ignores len
In-reply-to: <CAEudQAoHF228ovrBZrH0=k-=cwupRX5tvXZ31nod-H20YBTPbA@mail.gmail.com>
References: <Z64jD3u46gObCo1p@pryzbyj2023> <CAEudQAoHF228ovrBZrH0=k-=cwupRX5tvXZ31nod-H20YBTPbA@mail.gmail.com>
Comments: In-reply-to Ranier Vilela <ranier.vf@gmail.com>
	message dated "Thu, 13 Feb 2025 13:59:17 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3718760.1739473512.1@sss.pgh.pa.us>
Date: Thu, 13 Feb 2025 14:05:12 -0500
Message-ID: <3718761.1739473512@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3718761.1739473512%40sss.pgh.pa.us>
Precedence: bulk

Ranier Vilela <ranier.vf@gmail.com> writes:
> Interesting, Coverity has some new reports regarding PQescapeIdentifier.

> CID 1591290: (#1 of 1): Out-of-bounds access (OVERRUN)
> 2. alloc_strlen: Allocating insufficient memory for the terminating null of
> the string. [Note: The source code implementation of the function has been
> overridden by a builtin model.]

That's not new, we've been seeing those for awhile.  I've been
ignoring them on the grounds that (a) if the code actually had such a
problem, valgrind testing would have found it, and (b) the message is
saying in so many words that they're ignoring our code in favor of
somebody's apparently-inaccurate model of said code.

			regards, tom lane