From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Noah Misch <noah@leadboat.com>,
        Jacob Champion <jacob.champion@enterprisedb.com>,
        Denis Laxalde <denis.laxalde@dalibo.com>,
        vignesh C <vignesh21@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>,
        Greg Stark <stark@mit.edu>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        Jelte Fennema <Jelte.Fennema@microsoft.com>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter@eisentraut.org>,
        Andres Freund <andres@anarazel.de>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Robert Haas <robertmhaas@gmail.com>,
        pgsql-hackers@lists.postgresql.org,
        Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
In-reply-to: <202403281033.m43cmgh5mhz7@alvherre.pgsql>
References: <202403281033.m43cmgh5mhz7@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 28 Mar 2024 11:33:00 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <372768.1712179784.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 03 Apr 2024 17:29:44 -0400
Message-ID: <372769.1712179784@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/372769.1712179784%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Great, thanks for looking.  Pushed now, I'll be closing the commitfest
> entry shortly.

On my machine, headerscheck does not like this:

$ src/tools/pginclude/headerscheck --cplusplus
In file included from /tmp/headerscheck.4gTaW5/test.cpp:3:
./src/include/libpq/libpq-be-fe-helpers.h: In function 'char* libpqsrv_can=
cel(PGconn*, TimestampTz)':
./src/include/libpq/libpq-be-fe-helpers.h:393:10: warning: ISO C++ forbids=
 converting a string constant to 'char*' [-Wwrite-strings]
   return "out of memory";
          ^~~~~~~~~~~~~~~
./src/include/libpq/libpq-be-fe-helpers.h:421:13: warning: ISO C++ forbids=
 converting a string constant to 'char*' [-Wwrite-strings]
     error =3D "cancel request timed out";
             ^~~~~~~~~~~~~~~~~~~~~~~~~~

The second part of that could easily be fixed by declaring "error" as
"const char *".  As for the first part, can we redefine the whole
function as returning "const char *"?  (If not, this coding is very
questionable anyway.)

			regards, tom lane